DEPR: execute deprecations for str.cat in v1.0 #27611
Conversation
pandas/tests/test_strings.py
Outdated
| ) | ||
|
|
||
| result = s.str.cat(t, sep=sep) | ||
| print(s, t, result) |
doc/source/whatsnew/v1.0.0.rst
Outdated
| @@ -45,7 +45,7 @@ Backwards incompatible API changes | |||
| Other API changes | |||
| ^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - | |||
| - :meth:`pandas.Series.str.cat` now defaults to aligning ``others``, using ``join='left'`` (:issue:`27611`) | |||
There was a problem hiding this comment.
how is this an api change? isn't it just a deprecation removal?
There was a problem hiding this comment.
I thought that changing the default of a kwarg qualifies more as an API change than a removal, but I don't mind either way. Let me know if you want me to shift it.
There was a problem hiding this comment.
We have a "Removal of prior version deprecations/changes" section, which IIUC is appropriate here.
I think you might have mistyped with #22644? At least I don't see a relation. As mentioned in the OP:
|
|
Ping |
|
thanks @h-vetinari |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis executes some deprecations from the 0.23/0.24 cycles, namely following the switch from
join=Nonetojoin='left'(following #18657 / #20347), as well as the fact that list-likes within list-likes were deprecated (following #21950 / #22264).Since this deprecation closes the loop to my first-ever pandas issue (#18657) and PR (#20347), I'll allow myself a bit of a digression here. After biting off a bit more than I could chew (after finding out just how many cases the method was supposed to support), things got a bit tight with the cut-off for
0.23.0rc, and @TomAugspurger quipped:After #20347 #20790 #20842 #20845 #20923 #21330 #21950 #22264 #22575 #22652 #22721 (-->#23011 #23163 #23167 #23582 ... and several more issues/PRs around
.str-accessor) #22722 #22725 #23009 (-->#23061 #23065) #23187 #23443 #23723 #23725 #24044 #24045 #26605 #26607 etc., I think I can say that I upheld my end of the bargain. :)