BUG: error in read_excel with some ods files #45598 #46050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Feb 18, 2022
pandas/io/excel/_odfreader.py
Outdated
| sheet_cells = [ | ||
| x | ||
| for x in sheet_row.childNodes | ||
| if "qname" in dir(x) and x.qname in cell_names |
There was a problem hiding this comment.
@phofl The tests are passing only with if "qname" in dir(x) and getattr(x, "qname") in cell_names. But I don't know if that's what you meant.
jreback
requested changes
Feb 27, 2022
pandas/io/excel/_odfreader.py
Outdated
| sheet_cells = [ | ||
| x | ||
| for x in sheet_row.childNodes | ||
| if "qname" in dir(x) and x.qname in cell_names |
jreback
approved these changes
Mar 1, 2022
phofl
reviewed
Mar 1, 2022
pandas/tests/io/excel/test_odf.py
Outdated
|
|
||
|
|
||
| def test_read_newlines_between_xml_elements_table(): | ||
| # Also test reading table from an text OpenDocument file |
There was a problem hiding this comment.
Please add gh reference with GH#number
There was a problem hiding this comment.
You don‘t need the comment, the reference is enough
There was a problem hiding this comment.
@phofl Done! But thanks! Good to know for my next PRs!
rhshadrach
approved these changes
Mar 2, 2022
phofl
approved these changes
Mar 3, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…-dev#46050) * BUG: error in read_excel with some ods files pandas-dev#45598 * BUG: use hasattr instead of dir * DOC: add issue number in new test case * DOC: remove comment Co-authored-by: Dimitra Karadima <dkaradima@convertgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.5.0.rstfile if fixing a bug or adding a new feature.