ENH: Add lazy copy for sort_index #50491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/conftest.py
Outdated
| @@ -1903,6 +1903,7 @@ def using_copy_on_write() -> bool: | |||
| """ | |||
| Fixture to check if Copy-on-Write is enabled. | |||
| """ | |||
| pd.options.mode.copy_on_write = True | |||
There was a problem hiding this comment.
I suppose this is a leftover from local testing?
There was a problem hiding this comment.
BTW, for testing, you can set the env variable PANDAS_COPY_ON_WRITE=1 pytest ..., which is of course a bit verbose. What I do locally is that I have an alias in my bashrc, so I can just do COW pytest ..., and then it is quite easy to switch between COW pytest ... or pytest ... when I want to run a specific test while developing with both COW enabled or not.
There was a problem hiding this comment.
Yeah agreed, did this when running tests in PyCharm
There was a problem hiding this comment.
Ah, I can't speak for PyCharm ;)
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.