Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/VIS: rot and fontsize are not applied to timeseries plots #7844

Merged
merged 1 commit into from
Jul 28, 2014

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Jul 25, 2014

In some plots, rot and fontsize arguments are not applied properly.

  • timeseries line / area plot: rot is not applied to minor ticklabels, and fontsize is completely ignored. (Fixed to apply to xticklabels)
  • kde plot: rot and fontsize are completely ignored. (Fixed to apply to xticklabels)
  • scatter and hexbin plots: rot and fontsize are completely ignored. (Under confirmation)
import pandas as pd
import numpy as np

df = pd.DataFrame(np.random.randn(10, 4), index=pd.date_range(start='2014-07-01', freq='M', periods=10))
df.plot(rot=80, fontsize=15)

Current Result

figure_ng

After Fix

figure_ok

@jreback jreback added this to the 0.15.0 milestone Jul 26, 2014
@sinhrks
Copy link
Member Author

sinhrks commented Jul 26, 2014

The problem affects to kde, scatter, and hexbin plots. These all ignores rot and fontsize now.

In kde, I think it is natural to use rot and fontsize for xticklabels. But in scatter and hexbin, maybe better to apply to both xticklabels and yticklabels? Or only to xticklabels?

jreback added a commit that referenced this pull request Jul 28, 2014
BUG/VIS: rot and fontsize are not applied to timeseries plots
@jreback jreback merged commit e04e0ec into pandas-dev:master Jul 28, 2014
@jreback
Copy link
Contributor

jreback commented Jul 28, 2014

@sinhrks thanks....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants