Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a parameter for the year needed #110

Open
CIOData opened this issue May 17, 2024 · 2 comments
Open

Have a parameter for the year needed #110

CIOData opened this issue May 17, 2024 · 2 comments
Labels
enhancement A suggestion or feature that improves existing functionality

Comments

@CIOData
Copy link

CIOData commented May 17, 2024

I was mapping county-level data today using usmap and realized that my values for Connecticut were being rejected. I am using data from 2016-2020, so it still has the older Connecticut counties in it, but apparently plot_usmap() only recognizes the new counties (which have different FIPS codes than the previous one). Would it be possible to allow a year argument so that the appropriate geometries get included for older data? I imagine this may come in useful in other circumstances as well (such as the ever evolving city/county issue in Virginia).

Thanks.

@CIOData CIOData added the enhancement A suggestion or feature that improves existing functionality label May 17, 2024
@pdil
Copy link
Owner

pdil commented May 17, 2024

Yes this is a good idea, I will have to do an analysis of the file sizes involved since adding too many yearly map data sets may increase the package size beyond the limit that CRAN recommends (I think 5 MB for data). Currently the usmapdata files that usmap uses take up about 3 MB uncompressed (~1 MB compressed) so there is probably room to add a few more years but either way I will investigate further.

@CIOData
Copy link
Author

CIOData commented May 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion or feature that improves existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants