Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checksums of Drive files #1311

Open
ajorg opened this issue Apr 26, 2024 · 2 comments
Open

Checksums of Drive files #1311

ajorg opened this issue Apr 26, 2024 · 2 comments
Assignees
@mdevaev
Labels
type:feature New feature or request

Comments

@ajorg
Copy link

ajorg commented Apr 26, 2024

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
It would be great if, after / during uploading / downloading a file, PiKVM would calculate checksums of the file. Especially when downloading from a URL, it would be good to be able to verify that the download matches the advertised checksum.

Checksums can be calculated while streaming data, so that could be a nice way to implement it. If not, it uses a lot of compute at once, so it might be best to have a button to trigger the calculation.

SHA-256 is considered standard today, but a lot of things still use SHA-1, and some still use MD5, so it might be wise to support multiple checksum types.

Describe alternatives you've considered
I could log into the PiKVM terminal and do a checksum myself, but that's quite tedious. Or I could do a checksum locally and hope nothing got corrupted.

Additional context
I mentioned the idea in the Discord #chat channel and a couple of folks there quickly agreed they've wanted this too.
@mdevaev
Copy link
Member

mdevaev commented May 1, 2024

Hi. I can do this and show checksums in the UI, but automatic comparison is hardly possible, because there is nothing to compare, there is no standard that describes where checksums should lie in relation to files in the URL.

@mdevaev mdevaev self-assigned this May 1, 2024
@mdevaev mdevaev added the type:feature New feature or request label May 1, 2024
@ajorg
Copy link
Author

ajorg commented May 1, 2024

I didn't mean to imply that the verification be automatic, only that the checksums be displayed so that verification is possible. Thanks for considering it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdevaev mdevaev

Labels
type:feature New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajorg @mdevaev