Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue when resolution change crashes text system #10916

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: issue when resolution change crashes text system #10916

merged 1 commit into from
Sep 11, 2024

Conversation

GoodBoyDigital
Copy link
Member

Description of change

Added a null check for destroyed GPU text.
fixes #10907

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@GoodBoyDigital GoodBoyDigital changed the title fix issue when resolution change crashes text system fix: issue when resolution change crashes text system Sep 10, 2024
github-actions[bot]
github-actions bot reviewed Sep 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9865a0:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Sep 11, 2024
@Zyie Zyie added this pull request to the merge queue Sep 11, 2024
Merged via the queue into dev with commit f199c93 Sep 11, 2024
5 of 6 checks passed
@Zyie Zyie deleted the fix/resolution-change branch September 11, 2024 12:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Awaiting requested review from Zyie

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Changing renderer resolution crashes if canvas text existed before
3 participants
@GoodBoyDigital @bigtimebuddy @Zyie