Use an enum that can be used for comparison in the app, like PlatformType

export enum ContainerEngine {
  Docker = 'docker',
  Podman = 'podman',
}

I have a slight preference for unions for being able to use values directly, still getting typescript lint errors as guard rails, and not requiring importing. If you still want enum, I can update it though

Don't make it optional as it won't be (always defaults to docker in the backend).

It defaults to docker when creating a new environment, but there's no guarantee (yet) that existing environments have the container engine set.

I'll look into doing a migration that either sets all existing environments to 'docker' or a post init migration that checks the info from environments to determine 'podman' or 'docker' environments.

If containerEngine is mandatory in the backend, don't make it optional in the frontend with a default value but enforce it along the entire call chain (in EnvironmentOptions and its callers)

If containerEngine is optional in the backend, don't use a default value.

This comment applies to all the containerEngine related parameters of this PR.

Fair point!

I think that containerEngine should be optional, for the following reasons

• we shouldn't set the containerEngine for kubernetes environments (it's specific for only docker or podman envs)
• there are existing environments that won't be migrated to have a containerEngine field

I've removed the default 'docker' value

In this case we should probably assume that the flag is disabled and not enabled by default. The purpose of a feature flag is to hide feature by default and only enable them on demand.

Also, use FeatureId.PODMAN or a custom hook (see above)

  const { data: isPodmanEnabled } = useFeatureFlag(FeatureId.PODMAN);
  const environmentTypes = getEnvironmentTypes(!!isPodmanEnabled);

OR

  const isPodmanEnabled = useIsPodmanEnabled();
  const environmentTypes = getEnvironmentTypes(isPodmanEnabled);

There's a weird exception where isPodmanEnabledQuery is still loading. I updated the comment and code to hopefully reflect this case better