Use DataModel::Provider provided command information to handle command validation #35897
+163
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35897: Size comparison from cc6c773 to af7552f Full report (16 builds for linux)
|
|
PR #35897: Size comparison from cc6c773 to 129ad24 Full report (9 builds for cc32xx, nxp, stm32)
|
|
PR #35897: Size comparison from cc6c773 to b08d16e Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
commented
Oct 4, 2024
| Access::Privilege requestPrivilege = RequiredPrivilege::ForInvokeCommand(concretePath); | ||
| err = Access::GetAccessControl().Check(subjectDescriptor, requestPath, requestPrivilege); | ||
| if (err != CHIP_NO_ERROR) | ||
| Status preCheckStatus = mpCallback->ValidateCommandCanBeDispatched(request); |
There was a problem hiding this comment.
Group commands seem to not validate fabric scoped nor timed invoke flags in previous implementations.
I am unclear why. @bzbarsky-apple @tcarmelveilleux is this a spec requirement? Wondering if I should add that logic (i.e. pass in that the command was invoked via group handling) to the validation or not .... To me it would make sense for validation to be uniform so I left it like that here.
|
PR #35897: Size comparison from dc3fcc8 to 4ec72e5 Full report (78 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When data model provider interface is available, the code now can use the data model flags for commands (required ACL, flags for needing timed invokes or being scoped) rather than direct generated-code dependencies.