Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DataModel::Provider provided command information to handle command validation #35897

Merged
merged 30 commits into from
Oct 9, 2024
Merged

Use DataModel::Provider provided command information to handle command validation #35897

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
17dcef6
A first pass to implement better invoke logic decoupling
andreilitvin Oct 3, 2024
3ed30ea
Fix some includes
andreilitvin Oct 3, 2024
6bd969d
Fix some includes
andreilitvin Oct 3, 2024
b63c918
More include fixes
andreilitvin Oct 3, 2024
0912e9a
Fix dependency to make things build
andreilitvin Oct 3, 2024
6386bf7
Fixed tests
andreilitvin Oct 3, 2024
4188ae5
Fix includes
andreilitvin Oct 3, 2024
af7552f
Restyle
andreilitvin Oct 3, 2024
129ad24
Fix naming typo
andreilitvin Oct 3, 2024
b08d16e
Fix tizen build
andreilitvin Oct 3, 2024
03dcc81
Fix condition typo
andy31415 Oct 4, 2024
d197a94
Keep group command logic to use continue instead of status return ...…
andy31415 Oct 4, 2024
f83397f
Merge branch 'master' into use_dm_for_command_validation
andy31415 Oct 4, 2024
4ec72e5
Minor update to kick restyler
andy31415 Oct 4, 2024
3d3e7f6
one more decoupling update: sligtly more inefficient, however likely …
andy31415 Oct 4, 2024
5ca78df
Renamed based on code review feedback
andy31415 Oct 4, 2024
e03197d
Restyled by clang-format
restyled-commits Oct 4, 2024
3cf6ff3
Fix some code review comments
andreilitvin Oct 8, 2024
6e77713
Review comment: default privilege to operate
andreilitvin Oct 8, 2024
99d0629
Fix up renames
andreilitvin Oct 8, 2024
5981a57
Fix hex prefix
andreilitvin Oct 8, 2024
f0968ae
Restyled by clang-format
restyled-commits Oct 8, 2024
649c50c
Merge branch 'master' into use_dm_for_command_validation
andy31415 Oct 8, 2024
c8efbbf
Fix cirque after log formatting change. Load bearing log ....
andreilitvin Oct 8, 2024
ae63895
Merge branch 'use_dm_for_command_validation' of github.com:andy31415/…
andreilitvin Oct 8, 2024
4f1f196
Revert file change that I did not mean to change
andreilitvin Oct 8, 2024
bab965a
Update src/app/CommandHandlerImpl.cpp
andy31415 Oct 9, 2024
fcdb555
Merge branch 'master' into use_dm_for_command_validation
andy31415 Oct 9, 2024
38e3bdb
Remove separate member for accessing fabric index
andy31415 Oct 9, 2024
e497eec
Restyled by clang-format
restyled-commits Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix dependency to make things build
  • Loading branch information
@andreilitvin
andreilitvin committed Oct 3, 2024
commit 0912e9ad37f7fcac04dcac32c74789cc89be241b
1 change: 1 addition & 0 deletions src/app/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ source_set("command-handler-impl") {
"${chip_root}/src/access:types",
"${chip_root}/src/app/MessageDef",
"${chip_root}/src/app/data-model",
"${chip_root}/src/app/data-model-provider",
"${chip_root}/src/app/util:callbacks",
"${chip_root}/src/lib/support",
"${chip_root}/src/messaging",
Expand Down