Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Fix bug where arrow_parquet_args aren't used #47161

Merged
merged 4 commits into from
Aug 30, 2024
Merged

[Data] Fix bug where arrow_parquet_args aren't used #47161

merged 4 commits into from
Aug 30, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

When you specify arrow_parquet_args, those arguments should be passed to PyArrow so that you can configure your writes. However, we weren't actually passing arrow_parquet_args to PyArrow. This PR fixes that bug.

Related issue number

Fixes #47153

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani enabled auto-merge (squash) August 15, 2024 19:20
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 15, 2024
@github-actions github-actions bot disabled auto-merge August 30, 2024 17:45
@scottjlee scottjlee enabled auto-merge (squash) August 30, 2024 17:46
@scottjlee scottjlee merged commit c03aeff into master Aug 30, 2024
5 of 6 checks passed
@scottjlee scottjlee deleted the fix-write-gzip branch August 30, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@c21 c21 Awaiting requested review from c21 c21 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees

@scottjlee scottjlee

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data] - Parquet writing/loading with GZIP compression does not work as expected.
2 participants
@bveeramani @scottjlee