-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close checks list when clicking outside of modal #7157
Comments
This could be done by adding a I could not get the dialog in the first link provided for examples though. |
That's too bad, GitHub has always dealt with modals pretty well, especially because they never had a darkened background so people don't even know it's a modal. We used to have a feature for that #735 For what it's worth, that modal can be closed via ESC |
Implemented on https://github.com/Katsute/refined-github/blob/9715f1caecd100c2b8c456b247a94d349e87c076/source/features/checks-modal.tsx using Should I open a PR for this feature? |
Description
Clicking anywhere outside the modal should just close it, every other modal that GH uses does close when you click outside the modal.
Click on the check:
Click anywhere outside the modal:
(modal does not close)
Example URLs
(any page that shows a commit check)
The text was updated successfully, but these errors were encountered: