Migrate to MV3 #7473
Migrate to MV3 #7473
Conversation
| @@ -17,23 +18,28 @@ | |||
| }, | |||
| "permissions": [ | |||
| "storage", | |||
| "scripting", | |||
There was a problem hiding this comment.
Explanation for the Chrome Web Store:
The scripting API is used to inject the content script into new hosts when granted by the user.
| "default_icon": "assets/icon.png" | ||
| }, | ||
| "optional_permissions": [ | ||
| "optional_host_permissions": [ |
There was a problem hiding this comment.
Firefox still doesn't support this. The good news is that it should be out on July 9th. I'll wait until then to merge this PR.
https://bugzilla.mozilla.org/show_bug.cgi?id=1766026
Other than this, GHE support seems to be unaffected in both Chrome and Firefox 🎉
| ] | ||
| { | ||
| "resources": [ "assets/resolve-conflicts.js" ], | ||
| "matches": [ "https://*/*" ] |
There was a problem hiding this comment.
Also verified to work on https://github.com/refined-github/sandbox/pull/82/conflicts
| @@ -17,23 +18,31 @@ | |||
| }, | |||
| "permissions": [ | |||
| "storage", | |||
| "scripting", | |||
| "contextMenus", | |||
| "activeTab", | |||
There was a problem hiding this comment.
Why is this permission required? There is a side-effect with Firefox MV3: this extension now "needs attention" on every tab that isn't GitHub.
There was a problem hiding this comment.
That's not it, see #7477
The permission is required in MV3 to add support for GitHub Enterprise
Thanks to all the work I've done supporting my
webext-*modules for PixieBrix, updating Refined GitHub meant changing only a few keys in the manifest. Now I just need to check what this means for GH Enterprise users.So this upgrade is sponsored by PixieBrix 🎉