-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to MV3 #7473
Migrate to MV3 #7473
Conversation
@@ -17,23 +18,28 @@ | |||
}, | |||
"permissions": [ | |||
"storage", | |||
"scripting", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation for the Chrome Web Store:
The scripting API is used to inject the content script into new hosts when granted by the user.
"default_icon": "assets/icon.png" | ||
}, | ||
"optional_permissions": [ | ||
"optional_host_permissions": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox still doesn't support this. The good news is that it should be out on July 9th. I'll wait until then to merge this PR.
https://bugzilla.mozilla.org/show_bug.cgi?id=1766026
Other than this, GHE support seems to be unaffected in both Chrome and Firefox 🎉
] | ||
{ | ||
"resources": [ "assets/resolve-conflicts.js" ], | ||
"matches": [ "https://*/*" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also verified to work on https://github.com/refined-github/sandbox/pull/82/conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked by Firefox. v128 will be out on July 9th.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Added GHE support for Firefox <128 so I don't have to wait. I tested the "invalid"
optional_permissions
array on the Chrome Web Store and it was fine - Fixed a bug where it would be injected multiple times on GHE as the worker restarts
@@ -17,23 +18,31 @@ | |||
}, | |||
"permissions": [ | |||
"storage", | |||
"scripting", | |||
"contextMenus", | |||
"activeTab", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not it, see #7477
The permission is required in MV3 to add support for GitHub Enterprise
Thanks to all the work I've done supporting my
webext-*
modules for PixieBrix, updating Refined GitHub meant changing only a few keys in the manifest. Now I just need to check what this means for GH Enterprise users.So this upgrade is sponsored by PixieBrix 🎉