also happy to do this differently, if desired:

1. only 1 line of textarea.classList.add('rgh-fit-textareas'); (instead of if/else)
2. add CSS to .rgh-fit-textareas class in source/features/fit-textareas.css to override the .js-size-to-fit styles

No conditions are necessary, you can just remove the class (whether it exists or not) and add the other. No "replace" call

sounds good:

• 05b6926

I believe this will break the manual resizing (you can drag the bottom right corner to resize it)

indeed it does 🤔 😟

the reason I added it was that:

1. the height: 100px !important below
2. height: <pixel value> was appearing as an inline style on some of these textareas - not sure where that was coming from though, so that may not be an unwanted thing

.issue-form-textarea {
    height: 100px !important;
    min-height: 100px !important;
}

but maybe I should just remove that .issue-form-textarea class instead (and probably others, eg. PRs, Discussions, etc, hmm...

if you have any suggestions, I can also see whether those would work

in addition to the styles above, there's also another block for the unfocused fields:

.form-group textarea.form-control {
    width: 100%;
    height: 200px;
    min-height: 200px;
}

where the height: 200px is also causing constraints there

Perhaps:

• remove the first class
• make the selector stronger to override the second rule

This way you don't need to use !important

But actually manual resizing isn't important on those fields, so we don't need to do anything there. However the current code also applies to other fields.

The solution is to move height: auto !important to a more specific selector, like .rgh-fit-textarea.issue-form-textarea

alright, I tried out the first approach:

• remove the first class 84903c6
• make selector stronger 8e890d6

if the height: auto !important with the .rgh-fit-textarea.issue-form-textarea selector is preferable after all, I can switch to that instead

No conditions are necessary, you can just remove the class (whether it exists or not) and add the other. No "replace" call

Don't all textareas have this class?

the focused textareas have this class (no .form-control class):

js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input rgh-fit-textareas js-saved-reply-shortcut-comment-field input-monospace rgh-seen--7661699013

even if height: auto (without !important) was applied in future to the focused textarea elements, it would still not cause a problem for the manual resizing, which sets an inline height, which is higher specificity

Selector not strong enough for me, it's 200px:

Should work

ok sounds good. interesting, wonder why that didn't show up for me - maybe I didn't test correctly

wonder why that didn't show up for me

My guess is that the browser isn't consistent in the injection order of the styles.