default-branch-button - Restore feature in sidebar
#7600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after: |
fregante
reviewed
Jul 26, 2024
fregante
approved these changes
Jul 26, 2024
fregante
reviewed
Jul 26, 2024
default-branch-button - z-index issue in file header overlapdefault-branch-button - Restore feature in sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #7549
Test URLs
Screenshot
When
default-branch-buttonappears in the header, we can find the closet container element so it works fine!But whetn it appears in the sidebar, the closet container element is null. And I think we don't need to add
rgh-z-index-5class in this situation.