netiquette - Hide from preview tab
#7613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we just merge the two features? 🤔 |
|
That was my first thought when I made #7514 but I put it off so we can have something usable first. I have no issue if you agree to merge them. |
|
The last rename was just a week ago #7570 and the feature wasn't mentioned anywhere else I think. Perfect time to roll it into netiquette and treat it as another rename. |
This comment has been minimized.
This comment has been minimized.
netiquette - Hide banners in preview tab
|
I'll merge them later together with the screenshot 🙏 I wanted to merge this as a bugfix first so it appears in the release notes. |
netiquette - Hide banners in preview tabnetiquette - Hide from preview tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7612
Test URLs
Screenshot
draft-pr-noticeScreen.Recording.2024-07-29.at.3.13.11.AM.mov
netiquetteScreen.Recording.2024-07-29.at.3.14.30.AM.mov