-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package 12factor and new Scheduler interface #696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejholmes
force-pushed
the
12factor
branch
2 times, most recently
from
December 13, 2015 14:24
042840d
to
4b07ba7
Compare
// was previously defined, then only a "worker" process was submitted, the | ||
// existing "web" process should be removed. | ||
type Runner interface { | ||
Run(Manifest) error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought. This might be better named Up
and we can have an optional Down
method that scales everything to 0 (e.g. Maintenance mode).
Closed
Gonna go ahead and close this. New CloudFormation scheduler was merged in #803 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this a proposal for a v2 version of the Scheduler interface. Not necessarily looking to get this merged quickly.
The more I think about it, the more I realize that our Scheduler interface is just a generic interface for running 12factor apps against a scheduling backend, like ECS, Nomad, Kubernetes, etc.
Empire's sole purpose is to take a manifest, perform some transformations on it (merging in environment variables, release version, image) and then pass it off to a scheduler. I think there's a lot of benefits to making this fact more explicit in the code base.
Goals of this PR
package twelvefactor
).This could probably be merged before we actually change Empire to start consuming it.
TODO
TaskDefinition
to get Task information, pull the tasks and then retrieve the task definition for the task.