add serde big array support (fixed #327) #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
requested changes
Aug 21, 2023
|
@fawdlstty thanks for the fix! I only have one that should be addressed. |
esteve
approved these changes
Aug 22, 2023
luca-della-vedova
pushed a commit
to luca-della-vedova/ros2_rust
that referenced
this pull request
Sep 20, 2023
* add serde big array support
esteve
added a commit
that referenced
this pull request
Oct 27, 2023
* WIP Add minimal TimeSource implementation Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Minor cleanup and code reorganization Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Minor cleanups, add debug code Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Minor cleanup Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Change safety note to reflect get_now safety Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix comment spelling Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> * Cleanup and add some docs / tests Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Avoid duplicated clocks in TimeSource Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Change _rcl_clock to just Mutex Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove Mutex from node clock Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Change Mutex<bool> to AtomicBool Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Avoid cloning message Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Minor cleanup, add dependency Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove hardcoded use_sim_time Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Cleanup remaining warnings / clippy Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix tests Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Refactor API to use ClockSource Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix Drop implementation, finish builder and add comments Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Minor cleanups Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix graph_tests Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove Arc from time source Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove Sync trait, format Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add comparison function for times, use reference to clock Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Implement Add<Duration> and Sub<Duration> for Time Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Make node pointer Weak to avoid memory leaks Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Cleanups Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * WIP change clock type when use_sim_time parameter is changed Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove need for mutex in node TimeSource Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Change get_clock() to return cloned Clock object Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Minor cleanup Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Refactor spin and spin_once to mimic rclcpp's Executor API (#324) * Added rclcpp/rclpy-like executor * Fix comments * add serde big array support (fixed #327) (#328) * add serde big array support * Fixed an issue where cpu usage remained at 100% (#330) * Make get_parameter pub(crate) Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Address review feedback Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Make time_source pub(crate), remove unused APIs Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * WIP parameter interface implementation Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Migrate to proposed API Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add API for mandatory and optional parameters Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * First round of unit tests for parameter API Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Make complex parameter types Arc Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * First attempt at undeclared parameter API Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * First attempt at automatic parameter undeclaring Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Change undeclared_parameter API to be more explicit Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Minor cleanup, use atomic for undeclared params Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add docs Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add more tests Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Update setter for optional parameters Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add unset api for optional parameters Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Cleanup and add helper functions for arrays Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add type alias Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Reduce number of generics, add more tests Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Refactor to include parameter ranges and read_only Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Refactor ranges Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Revert API change for range builder Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add ParameterValueError variant Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * First implementation of tentative API Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Rework API for unified declaration syntax Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add missing APIs Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add error variant for default out of range Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Refactor and remove duplicated code Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Revert change to parameter service file Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove time related changes Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Clarify doc for unset API Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix comments / TODOs Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove Arc<RwLock> wrapper from undeclared params Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add short description of deviations from other client libraries Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Address minor feedback Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove duplicated range Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Change maybe_from to try_from Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * WIP converting to default value builder argument Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add type for test Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Infer arrays and allow custom discriminators Signed-off-by: Michael X. Grey <grey@openrobotics.org> * Fix CI Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix some documentation Signed-off-by: Michael X. Grey <grey@openrobotics.org> * Fix doc link Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Minor cleanups and optimizations Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix outdated docstrings Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add links in documentation / address clippy warnings Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> --------- Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Signed-off-by: Michael X. Grey <grey@openrobotics.org> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Co-authored-by: Esteve Fernandez <33620+esteve@users.noreply.github.com> Co-authored-by: Fawdlstty <fawdlstty@users.noreply.github.com> Co-authored-by: Michael X. Grey <grey@openrobotics.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #327