Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mode configuration option to enable strict type checking #3

Merged
merged 1 commit into from
Mar 2, 2019
Merged

Add mode configuration option to enable strict type checking #3

merged 1 commit into from
Mar 2, 2019

Conversation

psirenny
Copy link
Contributor

@psirenny psirenny commented Mar 2, 2019

This allows one to enable flow's strict type checking: https://flow.org/en/docs/strict/.
A mode configuration option may be passed in so that strict or strict-local is enabled.

For example:

import flowEntry from 'rollup-plugin-flow-entry'

export default {
  input: './src/index.js',
  output: { file: './lib/index.js', format: 'cjs' },
  plugins: [
    flowEntry({ mode: 'strict-local' })
  ]
}

Would yield:

// @flow strict-local

export * from '../src/index.js'

swansontec
swansontec approved these changes Mar 2, 2019
View reviewed changes
Copy link
Owner

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a great PR. It has everything a maintainer could ask for, including docs and tests.

@swansontec swansontec merged commit 49f1763 into swansontec:master Mar 2, 2019
@swansontec
Copy link
Owner

Published as rollup-plugin-flow-entry@0.3.1.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swansontec swansontec swansontec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psirenny @swansontec