Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect org-hide-leading-stars and the org-hide face #19

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Kaligule
Copy link

This basically removes a feature since org-mode already has it.

This is already thought of in orgmode (see hide-leading-stars), we
shouldn't reimplement it in org-bullets. Also it sort of didn't work
in terminals.
@Kaligule
Copy link
Author

This adresses #16

@math0ne
Copy link

math0ne commented Jun 29, 2017

Thanks for that, have been struggling with what was causing this!

* org-bullets.el (org-bullets-bullet-map): Fix documentation style.
(org-bullets-level-char): Add docstring.
* org-bullets.el (org-bullets-face-name): Change customization type
  for nil or a face.  This allows auto-completing a face.
* org-bullets.el (org-bullets-mode): Replace the use of the
  interactive-only function `font-lock-fontify-buffer` to
  `font-lock-flush`.
Remove importing the `cl` feature since it’s not used anywhere
* org-bullets.el (org-bullets-mode): Use `add-text-properties` instead
  of `put-text-property`.  Add higlight mouse-face and help-echo
  message.
* org-bullets.el (org-bullets-compose-leading-stars): Add
  customization variable to set the composition behavior (replace
  characters).
(org-bullets--char-series): Add function to calculate the current
character from a series and the current level.
(org-bullets-mode): Add the series variable.  Add pattern matching
case for setting the series variable according to
`org-bullets-compose-leading-stars`.
* org-bullets.el (org-bullets--bullet-events): Rename
  `org-bullets-bullet-map` to `org-bullets--bullet-events` in order to
  include other event text-properties.
(org-bullets-mode): Use `org-bullets--bullet-events` instead of
hard-coding text properties.
* org-bullets.el (org-bullets-mouse-events): Add this customization
  variable to disable mouse events easily.
(org-bullets-mode): Refactor to only activate mouse events when
`org-bullets-mouse-events` is set.
* org-bullets.el (org-bullets-face-name): Add quote to symbol.
@rosstimson
Copy link

Removing code, fixes oddness, what could be better? Really hope to see this merged and pushed to MELPA, would be a shame to have to maintain a fork just for this fix.

Add several customization variables
@luluman
Copy link

luluman commented Feb 15, 2019

This patch is helpful and resolves the leading stars problem #16. Thanks, @Kaligule.

Really hope to see this merged and pushed to MELPA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants