Skip to content
This repository has been archived by the owner on May 3, 2023. It is now read-only.

Fix visible windows report for linux #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

exekias
Copy link

@exekias exekias commented Aug 17, 2016

Map State flag is IsViewable when the window is visible to the user

Map State flag is `IsViewable` when the window is visible to the user
@exekias
Copy link
Author

exekias commented Aug 17, 2016

this doesn't seem to work with Unity

@exekias exekias closed this Aug 17, 2016
@seletskiy
Copy link
Contributor

seletskiy commented Aug 17, 2016

@exekias: But it works for i3, so, maybe, add WM detection?

@sixstone-qq
Copy link

sixstone-qq commented Aug 17, 2016

@exekias It seems it is only failing for two different firefox windows in different virtual desktops. I don't know why, because Map State: IsViewable is always set, no matter which window is but the visible ones only includes the ones in the same virtual desktop the active window is and that firefox window.

@beyang
Copy link
Member

beyang commented Aug 18, 2016

@exekias Could you submit the patch as a separate implementation of the Tracker interface? See my comments here: #13 (comment)

@beyang
Copy link
Member

beyang commented Sep 5, 2016

Following up here: I tested this with Unity and indeed this approach does not work. In Unity, all windows listed by wmctrl -l seem to have Map State: IsViewable.

However, if this is a valid approach for i3 and other window managers, could someone refactor the change to be a different Tracker implementation and then use that implementation when the appropriate window manager is detected?

This should be a very simple change, but I am not the one to do it, because I do not use i3 or AwesomeWM, and so wouldn't be able to test it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants