Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and reenable flaky ReactorNetty2StompBrokerRelayIntegrationTests #29287

Open
sbrannen opened this issue Oct 8, 2022 · 0 comments
Open

Fix and reenable flaky ReactorNetty2StompBrokerRelayIntegrationTests #29287

sbrannen opened this issue Oct 8, 2022 · 0 comments
Labels
in: messaging Issues in messaging modules (jms, messaging) type: task A general task
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Oct 8, 2022

The tests in ReactorNetty2StompBrokerRelayIntegrationTests fail too frequently and need to be properly addressed.

@sbrannen sbrannen added in: messaging Issues in messaging modules (jms, messaging) type: task A general task labels Oct 8, 2022
@sbrannen sbrannen added this to the 6.0.0-RC1 milestone Oct 8, 2022
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Oct 8, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-RC1, 6.0.0-RC2 Oct 10, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-RC2, 6.0.0 Oct 18, 2022
@sbrannen sbrannen modified the milestones: 6.0.0, 6.0.x Nov 14, 2022
@sbrannen sbrannen changed the title Address flaky ReactorNetty2StompBrokerRelayIntegrationTests Fix and reenable flaky ReactorNetty2StompBrokerRelayIntegrationTests Nov 14, 2022
rstoyanchev added a commit that referenced this issue Nov 22, 2022
To see if it still fails on the CI server as it doesn't fail locally
for me, and if it does to get details to investigate.

See gh-29287
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue May 4, 2023
rstoyanchev added a commit that referenced this issue May 10, 2023
When ReactorNetty2StompBrokerRelayIntegrationTests fail, typically there
are multiple exceptions "Connection refused: /127.0.0.1:61613" that
appear after we've conneted, sent CONNECT, and expecting CONNECTED, but
that does not come within the 10 second timeout.

61613 is the default port for STOMP. However, in all integration tests
we start ActiveMQ with port 0 which results in a random port. Moreover,
the stacktrace is for Netty 4 (not 5), and the eventloop thread id's
are different than the one where the connection to the correct, random
port was established.

The suspicion is that these are log messages from
MessageBrokerConfigurationTests which focuses on testing configuration
but nevertheless as a bean starts and attempts to connect to the default
port and fails. Perhaps those attempts to connect on the default port
somehow affect the ActiveMQ server, and it stops responding.

This change adds a no-op TcpClient in MessageBrokerConfigurationTests
to avoid unnecessary attempts to connect that are not needed.

See gh-29287
rstoyanchev added a commit that referenced this issue May 10, 2023
@rstoyanchev rstoyanchev modified the milestones: 6.0.x, 6.1.x Jun 15, 2023
@rstoyanchev rstoyanchev modified the milestones: 6.1.x, 6.2.x Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging Issues in messaging modules (jms, messaging) type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants