Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SubstituteIndicator #1204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add SubstituteIndicator #1204

wants to merge 1 commit into from

Conversation

Cypher01
Copy link

Add SubstituteIndicator, coming from my spin-off project ta4j-extended

@TheCookieLab TheCookieLab self-requested a review October 25, 2024 22:41
@sgflt sgflt mentioned this pull request Oct 27, 2024
Closed
16 tasks
TheCookieLab
TheCookieLab requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@TheCookieLab TheCookieLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this could also be a TransformIndicator candidate.

@Cypher01
Copy link
Author

True, same as for NzIndicator, I think I'll create a separate PR and close this one in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCookieLab TheCookieLab TheCookieLab requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cypher01 @TheCookieLab