This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
chore: reorder pre-commit & pyupgrade --py39 #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move stuff around in a more correct order.
|
To solve the typeerror at runtime we need
The thought of the abstract class was to define the api for an implementation of the repository. something like this seems to work, I can make a PR if you want. diff --git a/src/core/repository/repository.py b/src/core/repository/repository.py
index d63b66c..17ff387 100644
--- a/src/core/repository/repository.py
+++ b/src/core/repository/repository.py
@@ -5,7 +5,7 @@ abstract class defines the methods all repositories needs to implement.
"""
import abc
import logging
-from typing import List, Optional
+from typing import List, Optional, Protocol
from sqlalchemy.orm.session import Session
@@ -20,7 +20,21 @@ class NotFound(Exception):
pass
-class AbstractProjectRepository(abc.ABC):
+class _ProjectRepositroy(Protocol):
+ def _add(self, project: model.Project) -> model.Project:
+ ...
+
+ def _save(self) -> None:
+ ...
+
+ def _get(self, reference: int) -> Optional[model.Project]:
+ ...
+
+ def _list(self) -> list[model.Project]:
+ ...
+
+
+class AbstractProjectRepository(abc.ABC, _ProjectRepositroy):
"""Abstract project repository defining minimum API of repository."""
def __init__(self) -> None:
@@ -65,24 +79,6 @@ class AbstractProjectRepository(abc.ABC):
"""Get a list off all Projects in repository."""
return self._list()
- @abc.abstractmethod
- def _add(self, project: model.Project) -> model.Project: # pragma: no cover
- raise NotImplementedError
-
- @abc.abstractmethod
- def _save(self) -> None: # pragma: no cover
- raise NotImplementedError
-
- @abc.abstractmethod
- def _get(
- self, reference: int
- ) -> Optional[model.Project]: # pragma: no cover
- raise NotImplementedError
-
- @abc.abstractmethod
- def _list(self) -> list[model.Project]: # pragma: no cover
- raise NotImplementedError
-
def __len__(self) -> int:
"""Get number of projects in repository.Also if the logging and |
|
Feel free to open a pull request. 😁 Thanks for the explanation. |
- replace abstract class with Protocol - rename repository.py to project.py
15b4872
to
75b0940
Compare
|
Did a rebase and force-push to remove my failed attempt at solving the issue. Seems to retain the author. Nice work! |
tomrtk
approved these changes
Mar 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a complaint from MyPy:
Not sure what this tells me.
I see that it's not implemented. Warranted a removal?