👷 Deploy request for slash-libraries pending review.

Visit the deploys page to approve it

@BO-LIKE-CHICKEN Hi! 👋
Looks like an interesting Pull Request. I have a minor comment to make! 🙏
I think I can shorten the 2 validations by utilizing regular expressions.

In my opinion, it becomes simpler and more readable..!
What do you think? 🤗

The code below passes both the existing and added test code!! 💪

(+) Additionally, slash should be written in English, and I understand that existing code written in Korean is being changed incrementally

+ export function isValidHexValue(hex: string) {
+  const regex = /^#?[0-9A-Fa-f]{6}$/;
+  return regex.test(hex);
+ }

export function hexToRgba(hex: string, alpha = 1) {
+  if (!isValidHexValue(hex)) {
+    throw new Error(`Invalid hex value: ${hex}`);
+  }

  if (!isAlphaValue(alpha)) {
    throw new Error(`Invalid alpha value(0~1): ${alpha}`);
  }

  const normalizedHex = hex.startsWith('#') ? hex.slice(1) : hex;

- if (normalizedHex.length !== 6) {
-   throw new Error(`잘못된 normalizedHex 값의 길이입니다. 정확히 6자리여야 합니다: ${normalizedHex}`);
- }

  const r = parseHexValueStr(normalizedHex.slice(0, 2));
  const g = parseHexValueStr(normalizedHex.slice(2, 4));
  const b = parseHexValueStr(normalizedHex.slice(4, 6));

-  if ([r, g, b].some(value => Number.isNaN(value) || !isRGBDecimalValue(value))) {
-    throw new Error(`잘못된 hex값 입니다: ${hex}`);
-  }

  return `rgba(${r},${g},${b},${alpha})`;
}

@BO-LIKE-CHICKEN Hi! 👋 Looks like an interesting Pull Request. I have a minor comment to make! 🙏 I think I can shorten the 2 validations by utilizing regular expressions.

In my opinion, it becomes simpler and more readable..! What do you think? 🤗

The code below passes both the existing and added test code!! 💪

(+) Additionally, slash should be written in English, and I understand that existing code written in Korean is being changed incrementally

+ export function isValidHexValue(hex: string) {
+  const regex = /^#?[0-9A-Fa-f]{6}$/;
+  return regex.test(hex);
+ }

export function hexToRgba(hex: string, alpha = 1) {
+  if (!isValidHexValue(hex)) {
+    throw new Error(`Invalid hex value: ${hex}`);
+  }

  if (!isAlphaValue(alpha)) {
    throw new Error(`Invalid alpha value(0~1): ${alpha}`);
  }

  const normalizedHex = hex.startsWith('#') ? hex.slice(1) : hex;

- if (normalizedHex.length !== 6) {
-   throw new Error(`잘못된 normalizedHex 값의 길이입니다. 정확히 6자리여야 합니다: ${normalizedHex}`);
- }

  const r = parseHexValueStr(normalizedHex.slice(0, 2));
  const g = parseHexValueStr(normalizedHex.slice(2, 4));
  const b = parseHexValueStr(normalizedHex.slice(4, 6));

-  if ([r, g, b].some(value => Number.isNaN(value) || !isRGBDecimalValue(value))) {
-    throw new Error(`잘못된 hex값 입니다: ${hex}`);
-  }

  return `rgba(${r},${g},${b},${alpha})`;
}

@ssi02014 Hello! First, the content you've suggested looks entirely valid :) Initially, I added features trying not to significantly alter the existing codebase structure. However, if it's possible to make changes for better functionality, it seems appropriate to modify it as you suggested. Additionally, thank you for letting me know that I am gradually changing from using Korean in slashes to English, and that I am incrementally changing existing code written in Korean!

Therefore, as you suggested, I have modified the code and further enhanced it by:

• Removing the remaining Korean from the test code.
• Writing tests for a broader range of edge cases.

These changes will enhance the readability of the code and make it easier for developers to understand by clearly defining the cases I support. Thank you for your suggestion!

@BO-LIKE-CHICKEN
Cool! It looks much better to me! 🚀
But in the end, it needs a review by a maintainer

@raon0211 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@BO-LIKE-CHICKEN Cool!