feat(@toss/react): useInterval stop/resume support #476
Conversation
|
@d0422 is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
|
Hello, thanks for your contribution! While this change helps the use of However, I think adding an What do you think? |
|
@raon0211 type IntervalOptions =
| number
| {
delay: number | null;
trailing?: boolean;
enabled?: boolean;
}; |
| } | ||
|
|
||
| const id = window.setInterval(tick, delay); | ||
| return () => window.clearInterval(id); | ||
| }, [delay, savedCallback]); | ||
| }, [delay, savedCallback, enabled]); |
There was a problem hiding this comment.
I think it would be better for us if we did not register a callback at all if it is not enabled like the following code.
useEffect(() => {
if (delay == null || !enabled) {
return;
}
const id = window.setInterval(tick, delay);
return () => window.clearInterval(id);
}, [delay, savedCallback, enabled]);
There was a problem hiding this comment.
Thank you for your feedback. I have reflected your opinion and added the corresponding test code.
Overview
When using Interval, sometimes you need to stop and resume the interval.
When configuring the carousel, if auto-turning is implemented through useInterval, the interval must be stopped when the user is in the middle of the slide, and the interval must be resumed when the slide is completed.
In this case, I suggest that if it returns the factors presented above in the hook, it will be easy to implement!
Accordingly, why don't you return the stop, resume function, and intervalRunning status.
PR Checklist