Cookbook reorganization #1359
Closed
Cookbook reorganization #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
4 tasks
added 2 commits
August 19, 2024 14:19
sfc-gh-chu
reviewed
Aug 20, 2024
| @@ -0,0 +1,177 @@ | |||
| # 🦙 LlamaIndex Integration | |||
There was a problem hiding this comment.
just curious why replace the notebooks with markdown? I thought some jupyter mkdocs extension does that for us
There was a problem hiding this comment.
Did this for these docs pages because they're not intended to be runnable notebooks anyways, and the extension does it for us but it's still kind of ugly compared to normal markdown. Perhaps there's some changes we can make to the extension to make that nicer in general, I can look into that.
sfc-gh-chu
approved these changes
Aug 20, 2024
2ca304c
to
58dc031
Compare
added 2 commits
August 20, 2024 16:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display examples nicely in docs cookbook + update some other docs examples to display nicely
Other details good to know for developers
Please include any other details of this change useful for TruLens developers.
Type of change
not work as expected)