Update langchain.py #1322
Closed
Update langchain.py #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed predict to invoke to match new langchain standards
| @@ -63,7 +63,7 @@ def _create_chat_completion( | |||
| **kwargs, | |||
| ) -> str: | |||
| if prompt is not None: | |||
| predict = self.endpoint.chain.predict(prompt, **kwargs) | |||
| predict = self.endpoint.chain.invoke(prompt, **kwargs) | |||
There was a problem hiding this comment.
Thank you so much, should we update tests for this?
| @@ -63,7 +63,7 @@ def _create_chat_completion( | |||
| **kwargs, | |||
| ) -> str: | |||
| if prompt is not None: | |||
| predict = self.endpoint.chain.predict(prompt, **kwargs) | |||
| predict = self.endpoint.chain.invoke(prompt, **kwargs) | |||
|
|
|||
| elif messages is not None: | |||
| messages = [_convert_message(message) for message in messages] | |||
There was a problem hiding this comment.
we might want to update the predict_messages to invoke as well while we are on this
6 tasks
|
Thanks @JulienSantiago ! I've moved your contribution to a new PR because of some significant refactoring. New pr is here: #1375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed predict to invoke to match new langchain standards