Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update langchain.py #1322

Closed
wants to merge 2 commits into from
Closed

Update langchain.py #1322

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
814bf3f
Update langchain.py
JulienSantiago Aug 2, 2024
db48e52
predict_messages -> invoke
sfc-gh-jreini Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trulens_eval/trulens_eval/feedback/provider/langchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def _create_chat_completion(
**kwargs,
) -> str:
if prompt is not None:
predict = self.endpoint.chain.predict(prompt, **kwargs)
predict = self.endpoint.chain.invoke(prompt, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, should we update tests for this?


elif messages is not None:
messages = [_convert_message(message) for message in messages]
Copy link
Contributor

@sfc-gh-dhuang sfc-gh-dhuang Aug 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to update the predict_messages to invoke as well while we are on this

Expand Down