Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1569937] App Versioning #1332

Closed
wants to merge 17 commits into from
Closed

[SNOW-1569937] App Versioning #1332

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
239ddd8
add alembic migrations
sfc-gh-chu Aug 9, 2024
4704a64
basic refactor
sfc-gh-chu Aug 9, 2024
65b420d
fix revisions
sfc-gh-chu Aug 9, 2024
0a95348
fix other references
sfc-gh-chu Aug 9, 2024
599af5f
fix all other references in docs, tests, examples
sfc-gh-chu Aug 9, 2024
212eff0
fix missing references
sfc-gh-chu Aug 9, 2024
4ed33b2
Merge branch 'main' into corey/app_version
sfc-gh-chu Aug 10, 2024
a2e0fa2
Merge branch 'main' into corey/app_version
sfc-gh-chu Aug 10, 2024
d9c03c0
Merge branch 'main' into corey/app_version
sfc-gh-chu Aug 12, 2024
a2efb26
more refactor
sfc-gh-chu Aug 12, 2024
c686d63
notebook refactor
sfc-gh-chu Aug 13, 2024
2afd624
add deprecation for app_id
sfc-gh-chu Aug 13, 2024
91892bf
Merge branch 'main' into corey/app_version
sfc-gh-chu Aug 13, 2024
9a78dc9
default None for popping app_id
sfc-gh-chu Aug 13, 2024
2a19ef7
Merge branch 'main' into corey/app_version
sfc-gh-chu Aug 13, 2024
9d2bf66
validate app name
sfc-gh-chu Aug 13, 2024
c9bef49
Merge branch 'main' into corey/app_version
sfc-gh-chu Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
default None for popping app_id
  • Loading branch information
@sfc-gh-chu
sfc-gh-chu committed Aug 13, 2024
commit 9a78dc9a652f6cfb0fa97aa5e94642638851dc01
2 changes: 1 addition & 1 deletion src/core/trulens/core/schema/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def __init__(
f.feedback_definition_id for f in kwargs.get("feedbacks", [])
]

if app_id := kwargs.pop("app_id"):
if app_id := kwargs.pop("app_id", None):
if app_version:
raise ValueError(
"Cannot provide both `app_id` and `app_version`."
Expand Down