Break assume return into a separate hook in the generalized hook framework #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 87.60% 87.61%
=======================================
Files 63 64 +1
Lines 7916 7922 +6
=======================================
+ Hits 6935 6941 +6
Misses 799 799
Partials 182 182 ☔ View full report in Codecov by Sentry. |
sonalmahajan15
approved these changes
Sep 30, 2024
10acb30
to
152ec48
Compare
yuxincs
added a commit
that referenced
this pull request
Oct 4, 2024
Similar to #279, this PR breaks the logic that splits the CFG block upon seeing a trusted function into a separate strongly-typed hook for better maintainability and slightly better performance (due to fewer lookups in hook points). It introduces no functionality changes. --------- Co-authored-by: Sonal Mahajan <101232472+sonalmahajan15@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the logic that returns nonnil producer in the new generalized hook framework into a new strongly-typed hook for better maintainability and slightly better performance (fewer look ups in all hook points). It introduces no functionality changes.