Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentencesearch returns images #442

Closed
bigabig opened this issue Oct 11, 2024 · 4 comments
Closed

sentencesearch returns images #442

bigabig opened this issue Oct 11, 2024 · 4 comments
Assignees

Comments

@bigabig
Copy link
Member

bigabig commented Oct 11, 2024

This similarity search should only return sentences / text files, right?

@bigabig
Copy link
Member Author

bigabig commented Oct 11, 2024

image

@bigabig
Copy link
Member Author

bigabig commented Oct 11, 2024

i created a new project and just crawled this website: https://www.tagesschau.de/inland/innenpolitik/spd-miersch-generalsekretaer-100.html

@floschne
Copy link
Member

It looks very suspicious to me... The similarity score between ANY image and ANY text is never higher than any text to another text. (commonly known as modality gap).

Might it be that this is a displaying bug or that some sdoc IDs got mixed up? Have you checked the raw output in the SwaggerUI ?

@bigabig
Copy link
Member Author

bigabig commented Oct 16, 2024

calling the endponit

{
  "proj_id": 1,
  "query": "Kanzler",
  "top_k": 100,
  "threshold": 0,
  "filter": {
    "id": "string",
    "items": [],
    "logic_operator": "or"
  }
}

returns

[
  {
    "sdoc_id": 2,
    "score": 0.9917974472045898,
    "sentence_id": 201
  },
  {
    "sdoc_id": 1,
    "score": 0.9906548261642456,
    "sentence_id": 7
  },
  {
    "sdoc_id": 1,
    "score": 0.9906548261642456,
    "sentence_id": 14
  },
  {
    "sdoc_id": 1,
    "score": 0.9906548261642456,
    "sentence_id": 28
  },
  {
    "sdoc_id": 2,
    "score": 0.9906548261642456,
    "sentence_id": 108
  },
  ....

sdoc_id 2 is an image.

I mean even images have text documents (the automatically generated caption) however, this caption should only be returned once, as it most of the time only consists of one sentence. maybe there a bug related to embedding the caption?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants