Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify MemoCreate validation #323

Open
raffomania opened this issue Jan 11, 2024 · 0 comments
Open

Simplify MemoCreate validation #323

raffomania opened this issue Jan 11, 2024 · 0 comments

Comments

@raffomania
Copy link
Contributor

In #309 we created a new validate_condition function which is mostly used for checking whether project memos match the project of the object they are being attached to.

We can simplify this by removing the project_id field from the MemoCreate class and reading the project id in the backend from the object the memo is being attached to instead.

@raffomania raffomania self-assigned this Jan 11, 2024
@raffomania raffomania removed their assignment Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant