Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for LibreOffice 5.x.x.x on macOS. #442

Merged
merged 7 commits into from
Mar 10, 2018
Merged

Adds support for LibreOffice 5.x.x.x on macOS. #442

merged 7 commits into from
Mar 10, 2018

Conversation

devinea
Copy link
Contributor

@devinea devinea commented Mar 9, 2018 •
edited
Loading

Adds support for LibreOffice 5.x.x.x on macOS.
Travis CI is passing ✅ https://travis-ci.org/dagwieers/unoconv/builds/351566108
The following should work
/Applications/LibreOffice.app/Contents/Resources/python unoconv -V

Fixes these issues
#391
#263

@dagwieers @regebro - Please review.
BTW: Great project.

@devinea devinea closed this Mar 9, 2018
@devinea devinea changed the title Osx test Fix macOS with latest LibreOffice Mar 10, 2018
@devinea devinea changed the title Fix macOS with latest LibreOffice Fix macOS with latest LibreOffice 5.x.x.x Mar 10, 2018
@devinea devinea reopened this Mar 10, 2018
@devinea devinea changed the title Fix macOS with latest LibreOffice 5.x.x.x Adds support for LibreOffice 5.x.x.x on macOS. Mar 10, 2018
regebro
regebro approved these changes Mar 10, 2018
View reviewed changes
Copy link
Member

@regebro regebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems straightforward. Thanks!

@regebro regebro merged commit 5719f58 into unoconv:master Mar 10, 2018
@devinea devinea deleted the osx branch March 12, 2018 17:28
@devinea
Copy link
Contributor Author

devinea commented Mar 12, 2018

Thanks @regebro

qfz9527 pushed a commit to qfz9527/unoconv that referenced this pull request Mar 17, 2018
Merge pull request #1 from dagwieers/master
a378d1b 
update from origin Add support for LibreOffice 5.x.x.x on macOS.  (unoconv#442)
@simkimsia
Copy link
Contributor

simkimsia commented Apr 12, 2018 •
edited
Loading

What about libreoffice 6.x.x on mac os x? I have downloaded the DMG from libreoffice and inside apparently has no internal python script

My error is /Applications/LibreOffice.app/Contents/Resources/../Frameworks/LibreOfficePython.framework/Versions/3.5/Resources/Python.app/Contents/MacOS/LibreOfficePython: can't open file 'unoconv': [Errno 2] No such file or directory

UPDATE:

I have looked at this pull request, and I am slightly confident I can also solve this in a similar way.

My only issue is how do I change the unoconv file and test it?

I have:

  1. sudo chmod 755 /usr/local/Cellar/unoconv/0.8.2/bin/unoconv
  2. then edited the code
  3. then run /Applications/LibreOffice.app/Contents/Resources/python unoconv -f pdf examples/c08_1_read_from_range/9cell_range.xlsx
  4. I have deliberately uncommented the various debug_office lines. but nothing seems to make a difference. I don't even see the debug lines.

Please advise on teaching me how to edit the unoconv that I installed from homebrew so I can write a PR to resolve this.

@devinea , do you mind giving me a suggestion for this? Thank you

@amotl amotl mentioned this pull request Apr 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regebro regebro regebro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devinea @simkimsia @regebro