Fix docs for v0.57.2 #1987
Open
Fix docs for v0.57.2 #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2024 16:50
With the latest goreleaser, using the `--rm-dist` flag leads to an error: ``` error=unknown flag: --rm-dist ``` Instead, the recommendation is to use `--clean` instead. Signed-off-by: Nikhita Raghunath <nikhita.raghunath@broadcom.com>
https://sonobuoy.io/docs defaults to https://sonobuoy.io/docs/v0.57.2 and we missed adding content for v0.57.2. This commits copies over the content from the `main` branch and updates some metadata to point to v0.57.2. Signed-off-by: Nikhita Raghunath <nikhita.raghunath@broadcom.com>
9e303bc
to
ef182f0
Compare
|
@mohitsharma-in can you review? |
| If you're encountering rate limit on this, you can use VMware-provided mirror with: | ||
|
|
||
| ```bash | ||
| sonobuoy run --sonobuoy-image projects.registry.vmware.com/sonobuoy/sonobuoy:<VERSION> |
There was a problem hiding this comment.
We don't have latest version on this might need to manually sync from dockerhub or update dockerhub ref
| Then on running conformance: | ||
|
|
||
| ```bash | ||
| sonobuoy run --sonobuoy-image projects.registry.vmware.com/sonobuoy/sonobuoy:<VERSION> --e2e-repo-config conformance-image-config.yaml |
There was a problem hiding this comment.
probably change this to sonobuoy/sonobuoy https://hub.docker.com/r/sonobuoy/sonobuoy/tags
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
https://sonobuoy.io/docs defaults to https://sonobuoy.io/docs/v0.57.2
and we missed adding content for v0.57.2.
This commits copies over the content from the
mainbranchand updates some metadata to point to v0.57.2.
Special notes for your reviewer:
This PR also has an additional fix to github actions to fix the goreleaser command. We download the latest version of goreleaser and it doesn't support the
--rm-distflag.Release note: