Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of the colang plugin. #2

Merged
merged 1 commit into from Jun 24, 2021
Merged

First version of the colang plugin. #2

merged 1 commit into from Jun 24, 2021

Conversation

drazvan
Copy link
Contributor

@drazvan drazvan commented May 28, 2021

A first implementation of exporting a Voxable project into Colang. It doesn't have support for contexts yet.

The output is dumped at stdout and can be copy-pasted into the colang playground to play with.

@techpeace
Copy link
Member

Thanks so much again for being our first contributor, @drazvan! 😃 I'll be reviewing & merging this ASAP.

I wanted to let you know that we just relicensed the project to the BSD 3-Clause License. It's essentially the same as the MIT License, with one additional clause to protect the Voxable trademark.

This was just based on advice we received and isn't related to any changes in this PR. I just wanted to let you know since you're our only contributor so far, and we made this change after you submitted your code.

@techpeace techpeace self-assigned this Jun 2, 2021
@drazvan
Copy link
Contributor Author

drazvan commented Jun 12, 2021

Thanks so much again for being our first contributor, @drazvan! 😃 I'll be reviewing & merging this ASAP.

I wanted to let you know that we just relicensed the project to the BSD 3-Clause License. It's essentially the same as the MIT License, with one additional clause to protect the Voxable trademark.

This was just based on advice we received and isn't related to any changes in this PR. I just wanted to let you know since you're our only contributor so far, and we made this change after you submitted your code.

Thanks for the info, Matt. Yes, the BSD 3 license ok for my contribution ;)

Copy link
Member

@techpeace techpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently down a rabbithole trying to figure out why I can't use bin/run locally. Other than the above, the only issue I've seen so far is that yarn run prepack is throwing TypeScript compilation errors which will prevent the plugin from installing.

I'll go ahead and merge this and resolve that issue before I release this package.


import cli from 'cli-ux'

export default class Transform extends Base {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely understand the rationale of changing the command name to export rather than transform, since technically, it's exporting and then transforming. transform should probably be reserved for a command to run against an already-exported flat file. I'll make that change after I merge this plugin.

Though it of course doesn't matter, I'll also rename this class to match.

@techpeace techpeace merged commit bab4673 into voxable:master Jun 24, 2021
@techpeace techpeace added the enhancement New feature or request label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants