Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-scroll-snap] Should negative scroll-padding be allowed? #1084

Closed
fantasai opened this issue Mar 7, 2017 · 6 comments
Closed

[css-scroll-snap] Should negative scroll-padding be allowed? #1084

fantasai opened this issue Mar 7, 2017 · 6 comments
Assignees
Labels
Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-scroll-snap-1 Current Work Needs Testcase (WPT)

Comments

@fantasai
Copy link
Collaborator

fantasai commented Mar 7, 2017

Was flipping through old comments and noted that we forgot to consider whether scroll-snap-padding should be restricted to non-negative values. In light of that discussion, I think we should go ahead and disallow negative values.

Thoughts?

@tabatkins
Copy link
Member

Padding is already restricted to non-negative, and scroll-snap-padding's purpose is to make sure the snapped points don't get overlapped by other stuff positioned at the edges of the screen. A negative scroll-snap-padding would void that, as the scroller itself would overlap it.

So 👍

@frivoal
Copy link
Collaborator

frivoal commented Mar 13, 2017

Agreed. I suspect that if somebody actually came up with use cases, these would more likely be solved by introducing a scroll-(snap-)margin and allowing that to be negative.

@frivoal frivoal assigned frivoal and unassigned frivoal Mar 13, 2017
@frivoal frivoal added the css-scroll-snap-1 Current Work label Mar 13, 2017
@tabatkins
Copy link
Member

Agenda+ to approve this normative change (restricting scroll-padding to non-negative values only).

@tabatkins tabatkins reopened this May 15, 2017
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed Scroll snap, and agreed to the following resolutions:

  • RESOLVED: Accept the spec text proposed in https://github.com/w3c/csswg-drafts/issues/1084
The full IRC log of that discussion <dael> topic: Scroll snap
<dael> github topic: https://github.com//issues/1084
<dael> astearns: Looking for WG approval for this change.
<dael> astearns: Objections?
<dael> RESOLVED: Accept the spec text proposed in https://github.com//issues/1084

@fantasai fantasai added Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels May 17, 2017
@fantasai fantasai changed the title [css-scroll-snap] Should negative scroll-snap-padding be allowed? [css-scroll-snap] Should negative scroll-padding be allowed? May 17, 2017
@astearns
Copy link
Member

I'm assuming we need one or more testcases for this change

@astearns
Copy link
Member

Reopening for testcase need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-scroll-snap-1 Current Work Needs Testcase (WPT)
Projects
None yet
Development

No branches or pull requests

5 participants