Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.pringles.com - Middle of the page onwards is rendered incorreclty #123285

Closed
przemo20 opened this issue Jun 6, 2023 — with webcompat-app · 6 comments
Closed

www.pringles.com - Middle of the page onwards is rendered incorreclty #123285

przemo20 opened this issue Jun 6, 2023 — with webcompat-app · 6 comments
Labels
browser-firefox diagnosis-priority-p1 engine-gecko The browser uses the Gecko rendering engine priority-normal severity-minor The site has a cosmetic issue. trend-layout OKR Label - issues related to graphic glitches / broken UI causing issues with the page layout
Milestone

Comments

@przemo20
Copy link

przemo20 commented Jun 6, 2023

URL: https://www.pringles.com/pl/summer-pringles.html

Browser / Version: Firefox 113.0
Operating System: Windows 10
Tested Another Browser: Yes Chrome

Problem type: Design is broken
Description: Items are misaligned
Steps to Reproduce:
The “bottom” part of the page is displayed incorrectly on Firefox (tested it on the version 113.0.2 and Nightly [116.0a1 (2023-06-05)]). It looks fine on Chrome.

View the screenshot Screenshot
Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone Jun 6, 2023
@webcompat-bot webcompat-bot added browser-firefox engine-gecko The browser uses the Gecko rendering engine labels Jun 6, 2023
@softvision-raul-bucata
Copy link

We appreciate your report. I was able to reproduce the issue. The page from the middle down is rendered incorrectly :

Screenshot_2

Tested with:

Browser / Version: Firefox Release 113.0.2 (64-bit)/ Firefox Nightly 116.0a1 (2023-06-05) (64-bit) Chrome Version 114.0.5735.110 (Official Build) (64-bit)
Operating System: Windows 10 PRO x64

Notes:

  1. Reproducible regardless of the status of ETP.
  2. Reproducible on the latest build of Firefox Nightly and Release.
  3. Works as expected using Chrome:

Screenshot_1

Moving this to NeedsDiagnosis for further investigations.

[qa_23/2023]

@softvision-raul-bucata softvision-raul-bucata changed the title www.pringles.com - design is broken www.pringles.com - Middle of the page onwards is rendered incorreclty Jun 6, 2023
@softvision-raul-bucata softvision-raul-bucata added severity-minor The site has a cosmetic issue. priority-normal trend-layout OKR Label - issues related to graphic glitches / broken UI causing issues with the page layout labels Jun 6, 2023
@wisniewskit
Copy link
Member

They're using CSS :has(), which is not supported on Firefox yet:

.coreContainer:has(> #KSTL-landing-container-child-four-sub-child-two) #KSTL-landing-container-child-four-sub-child-two

But even with layout.css.has-selector.enabled enabled in about:config, the CSS doesn't seem to be applying. @dholbert, do you think this is related to the combination of CSS container queries and :has?

@dholbert
Copy link

I should probably redirect your question to @emilio who's more familiar with the state of our :has and container queries implementations -- emilio, could you take a look?

@dholbert
Copy link

(Or possibly @dshin-moz could take a look; he's working to get our :has impl to a state where we can turn it on. It's possible this is one of the known bugs in that feature.)

@dshin-moz
Copy link

Ah, this looks to be a static case (i.e. it doesn't get invalidated through JS), which we should be able to render correctly 116 on (i.e. After bug 1793012 resolved).
I can in fact confirm that on Nightly 116 on that this works correctly with layout.css.has-selector.enabled set.

@wisniewskit
Copy link
Member

Thanks! Then let's close this as a duplicate of the main :has bug for Firefox, since there isn't much we can do here if Pringles insists on using these new CSS features before they're considered stable.

@wisniewskit wisniewskit closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
@wisniewskit wisniewskit modified the milestones: needsdiagnosis, duplicate Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox diagnosis-priority-p1 engine-gecko The browser uses the Gecko rendering engine priority-normal severity-minor The site has a cosmetic issue. trend-layout OKR Label - issues related to graphic glitches / broken UI causing issues with the page layout
Projects
None yet
Development

No branches or pull requests

7 participants