Fix async when graphql not enabled #3246
Merged
+771
−193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3245
Description
This adds a
AsyncProviderService
that is injected into theAsyncExecutorService
to decouple theAsyncExecutorService
implementation from theJsonApi
andQueryRunners
implementations. These are now registered into theAsyncProviderService
.The
AsyncQueryOperation
implementations then get the providers that they need in the following manner.Motivation and Context
This fixes the bug where an exception is thrown when
elide.async.enabled
istrue
andelide.graphql.enabled
is false.This also allows the
elide-graphql
dependency to be excluded without errors if GraphQL is not required.How Has This Been Tested?
A
asyncEnabledJsonApiEnabledGraphqlNotEnabled
test was added toElideAutoConfigurationTest
.This was also tested manually with the
elide-spring-boot-example
by manually excluding theelide-graphql
dependency and exercising theasyncQuery
andtableExport
functionality.License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.