-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated 179 broken links #1281
base: develop
Are you sure you want to change the base?
Conversation
Hi @k3agan, thank you for the help with the links update! |
Hi @k3agan , |
Hi Fabiana, thanks for letting me know, I am updating it now
…On Thu, Mar 16, 2023 at 4:29 PM Fabiana ***@***.***> wrote:
Hi @k3agan <https://github.com/k3agan> ,
your commit message is not following the linter format. May I ask you to
update it so we can merge your PR?
—
Reply to this email directly, view it on GitHub
<#1281 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANOBKLODJDBWGQFESSEKH2LW4OO5JANCNFSM6AAAAAAVV2GECU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Just refreshed my branch, I can do it! Sorry still new at this 😃 |
Hi @fabclmnt , I've just pushed the new commit that addresses the linting issues you pointed out. Apologies for any confusion my previous commit may have caused, and I appreciate your patience as I continue to learn the ropes. Thank you for your guidance in helping me get this pull request up to par. I believe the pull request should now be in line with the defined standards. Please let me know if any additional changes are required. Best regards, Keagan |
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #1281 +/- ##
========================================
Coverage 90.37% 90.37%
========================================
Files 185 185
Lines 5725 5725
========================================
Hits 5174 5174
Misses 551 551
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This is a learning moment for me 😆 edit: All fixed. So apparently both the commit and the pull request need semantic messages. |
@k3agan any particular reason to change this link? (don't worry too much about the commit semantic, we're squashing everything) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the kaggle repo link should be replaced by this one
https://github.com/Kaggle/docker-python/blob/main/Dockerfile.tmpl
4500563
to
cfb020d
Compare
yamw