Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler API common function names conflict with other libraries #215

Closed
kevswims opened this issue Aug 26, 2024 · 1 comment
Closed

Profiler API common function names conflict with other libraries #215

kevswims opened this issue Aug 26, 2024 · 1 comment

Comments

@kevswims
Copy link

Since the core API in https://github.com/yse/easy_profiler/blob/develop/easy_profiler_core/include/easy/profiler.h is inside an extern "C" block, any functions declared that match the function names of another library will cause linking to fail.

In our particular case, the now and version functions are conflicting with the same functions in libsystemd.

There is a PR here #188 that covers some of these functions but not the now() function.

The posted PR looks like it would fix our issues if the now() function was also renamed. Is there anything blocking that PR or another approach that should be taken to fix this?

@yse
Copy link
Owner

yse commented Sep 20, 2024

Thank you for feedback. I've been merged the PR. Check latest develop version. Also merged PR with Qt6 migration

@yse yse closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@yse @kevswims and others