Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note about 2.7 and Item.evaluatedInclude / unevaluatedInclude #62

Open
3F opened this issue Jun 5, 2024 · 0 comments
Open

Note about 2.7 and Item.evaluatedInclude / unevaluatedInclude #62

3F opened this issue Jun 5, 2024 · 0 comments
Labels
support

Comments

@3F
Copy link
Owner

3F commented Jun 5, 2024

Since the following was marked as Obsolete:

  • PropertyItem.evaluatedValue
  • PropertyItem.unevaluatedValue
  • Item.evaluatedInclude
  • Item.unevaluatedInclude

MvsSln/changelog.txt

Lines 93 to 95 in 63ad0f2

* CHANGED: Projects.Item and PropertyItem:
new ctors & renamed evaluatedValue, evaluatedInclude, unevaluatedValue, unevaluatedInclude
Old access still is available but marked as obsolete and scheduled to be removed in future versions.

it also contains aliases like:

MvsSln/MvsSln/Projects/PropertyItem.cs

Lines 171 to 175 in 63ad0f2

[Obsolete("Renamed as " + nameof(evaluated))]
public readonly string evaluatedValue => evaluated;
[Obsolete("Renamed as " + nameof(unevaluated))]
public readonly string unevaluatedValue => unevaluated;

MvsSln/MvsSln/Projects/Item.cs

Lines 191 to 195 in a00e3b3

[Obsolete("Renamed as " + nameof(unevaluated))]
public readonly string unevaluatedValue => unevaluated;
[Obsolete("Renamed as " + nameof(evaluated))]
public readonly string evaluatedValue => evaluated;

and... my bad, as you can see above.
2.7 accidentally got incompatible changes with Item.evaluatedInclude and Item.unevaluatedInclude.

Please either update your code to use modern unevaluated & evaluated
Or let me know if 63ad0f2 needs to be released asap.
@3F 3F added the support label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@3F