Issue 6624059: code review 6624059: io/ioutil: fix data race under the race detector

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6624059: code review 6624059: io/ioutil: fix data race under the race detector (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by dvyukov

Modified:
12 years, 1 month ago

Reviewers:

CC:
rsc, minux1, golang-dev

Visibility:
Public.

Description

io/ioutil: fix data race under the race detector See issue 3970 (it's already marked as Fixed).

Patch Set 1 #

Patch Set 2 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r a1bbd399fc9b https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
A	src/pkg/io/ioutil/blackhole.go	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
A	src/pkg/io/ioutil/blackhole_race.go	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/pkg/io/ioutil/ioutil.go	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 1 month ago (2012-10-07 14:37:44 UTC) #1

dvyukov

On 2012/10/07 14:44:21, minux wrote: > do you want to mention Issue 3970? thanks. done

12 years, 1 month ago (2012-10-07 14:51:36 UTC) #3

dvyukov

12 years, 1 month ago (2012-10-07 18:08:10 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=1e55cf10aa4f ***

io/ioutil: fix data race under the race detector
See issue 3970 (it's already marked as Fixed).

R=rsc, minux.ma
CC=golang-dev
http://codereview.appspot.com/6624059

Expand All Messages | Collapse All Messages