Page MenuHomePhabricator
Create Task
Maniphest T96917

Split up the details class into multiple OOjs UI widgets in separate files
Closed, ResolvedPublic
Actions

Description

This class looks too big to me - could have multiple field classes and conglomerate them in the details class. Or maybe OOUI will make this small enough that we don't need to split it up?

  • Split off uw.CampaignDetailsWidget from UploadWizardDetails
  • Split off uw.CategoriesDetailsWidget from UploadWizardDetails
  • Split off uw.DateDetailsWidget from UploadWizardDetails
  • Split off uw.DescriptionsDetailsWidget from UploadWizardDetails
  • Split off uw.LocationDetailsWidget from UploadWizardDetails
  • Split off uw.TitleDetailsWidget from UploadWizardDetails
  • Split off uw.OtherDetailsWidget from UploadWizardDetails

Details

SubjectRepoBranchLines +/-
Split off uw.CampaignDetailsWidget from UploadWizardDetails (and OOUI-ize)mediawiki/extensions/UploadWizardmaster+130 -120
Split off uw.OtherDetailsWidget from UploadWizardDetails (and OOUI-ize)mediawiki/extensions/UploadWizardmaster+93 -47
Split off uw.LocationDetailsWidget from UploadWizardDetails (and OOUI-ize)mediawiki/extensions/UploadWizardmaster+186 -129
Split off uw.TitleDetailsWidget from UploadWizardDetails (and OOUI-ize)mediawiki/extensions/UploadWizardmaster+311 -322
Split off uw.DescriptionsDetailsWidget from UploadWizardDetails (and OOUI-ize)mediawiki/extensions/UploadWizardmaster+446 -634
Split off uw.CategoriesDetailsWidget from UploadWizardDetails (improve warnings)mediawiki/extensions/UploadWizardmaster+237 -134
Split off uw.DateDetailsWidget from UploadWizardDetails (introduce uw.DetailsWidget)mediawiki/extensions/UploadWizardmaster+391 -137
Customize query in gerrit

Related Objects
Search...

Event Timeline

MarkTraceur created this task.Apr 22 2015, 8:56 PM
MarkTraceur raised the priority of this task from to Medium.
MarkTraceur updated the task description. (Show Details)
MarkTraceur added projects: Multimedia, UploadWizard.
MarkTraceur added subscribers: MarkTraceur, Aklapper.
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:24 PM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptSep 4 2015, 6:24 PM
• matmarex claimed this task.Oct 16 2015, 6:50 PM
• matmarex subscribed.

Dibs!

• matmarex added a parent task: T96914: Migrate UploadWizard UI elements to OOjs UI.Oct 23 2015, 5:05 PM
• matmarex mentioned this in T117117: Add a warning about choosing a date in the future.Oct 29 2015, 10:40 PM
• matmarex mentioned this in T117119: Change popups informing about user choosing non-existent categories to use the warning system.Oct 29 2015, 10:44 PM
gerritbot subscribed.Nov 5 2015, 1:00 AM

Change 251179 had a related patch set uploaded (by Bartosz Dziewoński):
Split off uw.DateDetailsWidget from UploadWizardDetails (introduce uw.DetailsWidget)

https://gerrit.wikimedia.org/r/251179

gerritbot added a project: Patch-For-Review.Nov 5 2015, 1:00 AM

Change 251180 had a related patch set uploaded (by Bartosz Dziewoński):
Split off uw.CategoriesDetailsWidget from UploadWizardDetails (improve warnings)

https://gerrit.wikimedia.org/r/251180

gerritbot added a comment.Nov 5 2015, 1:00 AM

Change 251181 had a related patch set uploaded (by Bartosz Dziewoński):
Split off uw.DescriptionsDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/251181

gerritbot added a comment.Nov 5 2015, 1:00 AM

Change 251182 had a related patch set uploaded (by Bartosz Dziewoński):
Split off uw.TitleDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/251182

• matmarex added a comment.Nov 5 2015, 1:08 AM

The first two changes, for date and categories, have very little user-visible changes and can be merged whenever.

The next two, for description and title, do shuffle the fields quite a bit and should be merged together to avoid weird-looking interface.

Remaining: location, other information, custom campaign fields.

• matmarex mentioned this in T117833: Use OOUI 'required' indicator for required fields.Nov 5 2015, 1:37 AM
gerritbot added a comment.Nov 6 2015, 12:29 PM

Change 251291 had a related patch set uploaded (by Bartosz Dziewoński):
Split off uw.LocationDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/251291

gerritbot added a comment.Nov 6 2015, 12:44 PM

Change 251488 had a related patch set uploaded (by Bartosz Dziewoński):
Split off uw.OtherDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/251488

• matmarex added a comment.EditedNov 6 2015, 12:52 PM
Old:
pasted_file (2×1 px, 213 KB)
New:
pasted_file (2×1 px, 212 KB)

I think this is basically it. This screenshot doesn't show per-file deed chooser, which is not pretty yet, and is being dealt with as T118906.

gerritbot added a comment.Nov 17 2015, 4:31 PM

Change 253627 had a related patch set uploaded (by Bartosz Dziewoński):
Split off uw.CampaignDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/253627

• matmarex renamed this task from Split up the details class into multiple classes and files to Split up the details class into multiple OOjs UI widgets in separate files.Nov 17 2015, 10:10 PM
• matmarex set Security to None.
• matmarex mentioned this in T97202: Enable various core modules for mobile to make UploadWizard work.Nov 18 2015, 10:45 PM
• matmarex mentioned this in T44775: Confusing annotation about mandatory fields in Special:UploadWizard.Nov 19 2015, 2:00 AM
gerritbot added a comment.Nov 19 2015, 8:14 PM

Change 251179 merged by jenkins-bot:
Split off uw.DateDetailsWidget from UploadWizardDetails (introduce uw.DetailsWidget)

https://gerrit.wikimedia.org/r/251179

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Nov 19 2015, 9:00 PM
gerritbot added a comment.Nov 19 2015, 9:33 PM

Change 251180 merged by jenkins-bot:
Split off uw.CategoriesDetailsWidget from UploadWizardDetails (improve warnings)

https://gerrit.wikimedia.org/r/251180

gerritbot added a comment.Nov 19 2015, 10:14 PM

Change 251181 merged by jenkins-bot:
Split off uw.DescriptionsDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/251181

Jdforrester-WMF updated the task description. (Show Details)Nov 19 2015, 10:52 PM
gerritbot added a comment.Nov 20 2015, 6:29 PM

Change 251182 merged by jenkins-bot:
Split off uw.TitleDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/251182

Jdforrester-WMF updated the task description. (Show Details)Nov 20 2015, 6:29 PM
Jdforrester-WMF updated the task description. (Show Details)Nov 20 2015, 6:41 PM
gerritbot added a comment.Nov 20 2015, 6:43 PM

Change 251291 merged by jenkins-bot:
Split off uw.LocationDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/251291

Jdforrester-WMF updated the task description. (Show Details)Nov 20 2015, 6:47 PM
gerritbot added a comment.Nov 20 2015, 6:49 PM

Change 251488 merged by jenkins-bot:
Split off uw.OtherDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/251488

gerritbot added a comment.Nov 20 2015, 7:06 PM

Change 253627 merged by jenkins-bot:
Split off uw.CampaignDetailsWidget from UploadWizardDetails (and OOUI-ize)

https://gerrit.wikimedia.org/r/253627

Jdforrester-WMF closed this task as Resolved.Nov 20 2015, 7:07 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF removed a project: Patch-For-Review.
• matmarex mentioned this in T96914: Migrate UploadWizard UI elements to OOjs UI.Dec 7 2015, 6:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits