Page MenuHomePhabricator
Create Task
Maniphest T360991

CI Blocker: Use of wfGetDB was deprecated in MediaWiki 1.39.
Closed, ResolvedPublic
Actions

Description

CI for Translate and CX / SX is blocked due to the above error.

See: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/164932/console

14:42:22 5) MediaWiki\Extension\DiscussionTools\Tests\ThreadItemStoreTest::testInsertThreadItems with data set #4 ('cases/ThreadItemStore/5change...tation')
14:42:22 Use of wfGetDB was deprecated in MediaWiki 1.39. [Called from MediaWiki\Extension\DiscussionTools\Tests\ThreadItemStoreTest::testInsertThreadItems in /workspace/src/extensions/DiscussionTools/tests/phpunit/ThreadItemStoreTest.php at line 71]
....
14:42:22 9) MergeUserTest::testBasicMerge
14:42:22 Use of wfGetDB was deprecated in MediaWiki 1.39. [Called from MergeUser::mergeEditcount in /workspace/src/extensions/UserMerge/includes/MergeUser.php at line 78]
....
14:42:22 12) MergeUserTest::testMergeEditcount
14:42:22 Use of wfGetDB was deprecated in MediaWiki 1.39. [Called from MergeUser::mergeEditcount in /workspace/src/extensions/UserMerge/includes/MergeUser.php at line 78]
`

See patches:

  1. 1013244: SX SectionSuggestion: Add isListable property and use it where needed | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/1013244
  2. 1007472: Add Echo notification to be sent on messages addition or removal | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1007472

Details

SubjectRepoBranchLines +/-
Unbreak CI: replace usage of wfGetDBmediawiki/extensions/MathSearchmaster+189 -52
Replace use of wfGetDB()mediawiki/extensions/UserMergemaster+14 -6
Replace wfGetDB() in test with $this->getDb()mediawiki/extensions/DiscussionToolsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

abi_ triaged this task as Unbreak Now! priority.Mar 26 2024, 10:48 AM
abi_ created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2024, 10:48 AM
Nikerabbit added a project: ci-test-error (WMF-deployed Build Failure).Mar 26 2024, 11:20 AM
Jdforrester-WMF claimed this task.Mar 26 2024, 11:27 AM
gerritbot added a comment.Mar 26 2024, 11:30 AM

Change #1014487 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/DiscussionTools@master] Replace wfGetDB() in test with $this->getDb()

https://gerrit.wikimedia.org/r/1014487

gerritbot added a project: Patch-For-Review.Mar 26 2024, 11:30 AM
gerritbot added a comment.Mar 26 2024, 12:00 PM

Change #1014492 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/UserMerge@master] Replace use of wfGetDB()

https://gerrit.wikimedia.org/r/1014492

WMDE-Fisch subscribed.Mar 26 2024, 12:08 PM
Dreamy_Jazz subscribed.Mar 26 2024, 12:13 PM

Also causing failure on the GlobalBlocking extension

gerritbot added a comment.Mar 26 2024, 12:17 PM

Change #1014492 merged by jenkins-bot:

[mediawiki/extensions/UserMerge@master] Replace use of wfGetDB()

https://gerrit.wikimedia.org/r/1014492

taavi mentioned this in T361002: Include dependencies of WMF deployed extensions in the WMF-deployed index.Mar 26 2024, 12:20 PM
gerritbot added a comment.Mar 26 2024, 12:22 PM

Change #1014487 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Replace wfGetDB() in test with $this->getDb()

https://gerrit.wikimedia.org/r/1014487

taavi closed this task as Resolved.Mar 26 2024, 12:24 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 26 2024, 1:00 PM
abi_ removed projects: ContentTranslation, MediaWiki-extensions-Translate.Mar 27 2024, 10:51 AM
Tacsipacsi edited projects, added DiscussionTools, MediaWiki-extensions-UserMerge; removed Patch-For-Review.Mar 30 2024, 2:14 PM
Tacsipacsi subscribed.
Physikerwelt added a project: MathSearch.Apr 3 2024, 9:48 AM
gerritbot added a comment.Apr 3 2024, 10:14 AM

Change #1016738 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Unbreak CI: replace usage of wfGetDB

https://gerrit.wikimedia.org/r/1016738

gerritbot added a project: Patch-For-Review.Apr 3 2024, 10:14 AM
Physikerwelt subscribed.Apr 3 2024, 10:21 AM

There are 700 more problems. As it is triaged as unbreak now, maybe reopening this issue is not the right thing to do, but I guess sooner the problems will pop up.

gerritbot added a comment.Apr 3 2024, 11:38 AM

Change #1016738 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Unbreak CI: replace usage of wfGetDB

https://gerrit.wikimedia.org/r/1016738

Physikerwelt mentioned this in rEMAS35d6997263ca: Unbreak CI: replace usage of wfGetDB.Apr 3 2024, 12:26 PM
Jdforrester-WMF added a comment.Apr 3 2024, 1:12 PM
In T360991#9683644, @Physikerwelt wrote:

There are 700 more problems. As it is triaged as unbreak now, maybe reopening this issue is not the right thing to do, but I guess sooner the problems will pop up.

No, this was an UBN task because it blocked WMF-production code. Non-production code doesn't get the same treatment for fixing deprecations; maintainers are expected to follow-up as they see fit, rather than us holding up everything.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits