Page MenuHomePhabricator

[Regression] Special Characters menu is opening up above the comment box in reply tool on talk pages
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Go to a talk page (Make sure DiscussionTools is enabled)
  2. Click on Reply to any comment
  3. When the Reply tool opens up, click on the Special Character insert option on the toolbar

Observed Result:
Special Characters menu is opening up on top of the comment box in reply tool on talk pages with an odd transition of the entire toolbar.

Expected Result:

I think It used to open up over the reply tool comment box, just how it opens anywhere else inside VisualEditor. For example:

Screenshot 2024-07-29 at 3.42.23 PM.png (892×992 px, 96 KB)

Browser: Chrome

Wiki: en.wiki

Environment: Production

Event Timeline

The appearance:

image.png (746×1 px, 122 KB)

...I agree that I feel this used to be different.

Okay, on a patchdemo back in February it looks like this instead:

image.png (730×1 px, 107 KB)

Change #1060145 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Fix attachment of toolbar dialogs

https://gerrit.wikimedia.org/r/1060145

Change #1060145 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix attachment of toolbar dialogs

https://gerrit.wikimedia.org/r/1060145