Page MenuHomePhabricator

MediaWiki-SearchComponent
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Issues relating to the search engine in MediaWiki core. This includes API, backend code, and user interfaces relating to Special:Search, Special:PrefixIndex, Special:AllPages, and OpenSearch.

For the search engine on Wikipedia and sister projects, see CirrusSearch instead.

Maintained by: Discovery-Search

Recent Activity

Today

Pppery moved T351578: special:prefixindex requires ability to toggle namespace on and off, ability lost sometime from To triage to Maintenance reports on the MediaWiki-Special-pages board.
Sat, Aug 17, 4:57 AM · Discovery-Search, MediaWiki-Search, MediaWiki-Special-pages

Tue, Aug 13

thiemowmde raised the priority of T323345: Vector search does unnecessary redirects (including a double redirect) when clicking a search result from High to Needs Triage.
Tue, Aug 13, 9:50 AM · WMDE-TechWish-Sprint-2024-08-13, WMDE-TechWish-Sprint-2024-07-24, WMDE-TechWish-Sprint-2024-07-10, WMDE-TechWish-Sprint-2024-06-26, Unplanned-Sprint-Work, Patch-For-Review, WMDE-TechWish-Maintenance, Advanced-Search, MediaWiki-Search, Desktop Improvements (Vector 2022)
thiemowmde moved T323345: Vector search does unnecessary redirects (including a double redirect) when clicking a search result from Tech Review to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2024-08-13 board.
Tue, Aug 13, 9:49 AM · WMDE-TechWish-Sprint-2024-08-13, WMDE-TechWish-Sprint-2024-07-24, WMDE-TechWish-Sprint-2024-07-10, WMDE-TechWish-Sprint-2024-06-26, Unplanned-Sprint-Work, Patch-For-Review, WMDE-TechWish-Maintenance, Advanced-Search, MediaWiki-Search, Desktop Improvements (Vector 2022)
thiemowmde claimed T323345: Vector search does unnecessary redirects (including a double redirect) when clicking a search result.
Tue, Aug 13, 9:42 AM · WMDE-TechWish-Sprint-2024-08-13, WMDE-TechWish-Sprint-2024-07-24, WMDE-TechWish-Sprint-2024-07-10, WMDE-TechWish-Sprint-2024-06-26, Unplanned-Sprint-Work, Patch-For-Review, WMDE-TechWish-Maintenance, Advanced-Search, MediaWiki-Search, Desktop Improvements (Vector 2022)
WMDE-Fisch moved T323345: Vector search does unnecessary redirects (including a double redirect) when clicking a search result from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2024-08-13 board.
Tue, Aug 13, 9:39 AM · WMDE-TechWish-Sprint-2024-08-13, WMDE-TechWish-Sprint-2024-07-24, WMDE-TechWish-Sprint-2024-07-10, WMDE-TechWish-Sprint-2024-06-26, Unplanned-Sprint-Work, Patch-For-Review, WMDE-TechWish-Maintenance, Advanced-Search, MediaWiki-Search, Desktop Improvements (Vector 2022)

Sat, Aug 10

valerio.bozzolan updated the task description for T106055: Improve "advanced search".
Sat, Aug 10, 9:23 PM · Epic, Discovery-ARCHIVED, MediaWiki-Search, UI-Standardization, Design, Wikimania-Hackathon-2015
valerio.bozzolan added a comment to T106055: Improve "advanced search".

(Sorry for necroposting I guess. Just trying to update with what I see... maybe already solved / not relevant anymore)

Sat, Aug 10, 9:23 PM · Epic, Discovery-ARCHIVED, MediaWiki-Search, UI-Standardization, Design, Wikimania-Hackathon-2015
Maintenance_bot removed a project from T358938: Search suggests the Special:RunJobs page on all wikis, even though it's unlisted and not appropriate to suggest: Patch-For-Review.
Sat, Aug 10, 10:30 AM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), MediaWiki-Search, Discovery-Search (Current work)
gerritbot added a comment to T358938: Search suggests the Special:RunJobs page on all wikis, even though it's unlisted and not appropriate to suggest.

Change #1011334 abandoned by Jforrester:

[mediawiki/core@master] Specials: Proved UnlistedFormSpecialPage and ListedRedirectSpecialPage

Reason:

Lack of interest.

https://gerrit.wikimedia.org/r/1011334

Sat, Aug 10, 10:23 AM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), MediaWiki-Search, Discovery-Search (Current work)
Maintenance_bot removed a project from T344806: cirrussearch-ignored-headings is used in WikiTextStructure: Patch-For-Review.
Sat, Aug 10, 9:30 AM · MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Technical-Debt, MediaWiki-Search, Discovery-Search
gerritbot added a comment to T344806: cirrussearch-ignored-headings is used in WikiTextStructure.

Change #1057978 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] i18n: Drop 'cirrussearch-ignored-headings', now unused

https://gerrit.wikimedia.org/r/1057978

Sat, Aug 10, 9:25 AM · MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Technical-Debt, MediaWiki-Search, Discovery-Search

Fri, Aug 9

TheDJ added a comment to T107875: Use InnoDB engine for searchindex table in MySQL.

Discussed this with @Ladsgroup
We concluded that this is simply not really worth the effort in the this patch round. As Wikimedia doesn't rely on it, rearchitecting the testcases of Wikimedia to not so strongly depend on searchindex will needlessly complicate things. Instead, I'll provide maintenance script to convert to innodb for those who desire this.

Fri, Aug 9, 5:03 PM · User-TheDJ, Patch-Needs-Improvement, MediaWiki-Installer, MediaWiki-Search

Mon, Aug 5

ReleaseTaggerBot added a project to T365565: InvalidArgumentException: Value 4 must be either string or LikeMatch: MW-1.42-notes.
Mon, Aug 5, 7:00 AM · MW-1.42-notes, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), MediaWiki-Search, Wikimedia-production-error, Discovery-Search
Maintenance_bot removed a project from T365565: InvalidArgumentException: Value 4 must be either string or LikeMatch: Patch-For-Review.
Mon, Aug 5, 6:30 AM · MW-1.42-notes, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), MediaWiki-Search, Wikimedia-production-error, Discovery-Search
gerritbot added a comment to T365565: InvalidArgumentException: Value 4 must be either string or LikeMatch.

Change #1059485 merged by jenkins-bot:

[mediawiki/core@REL1_42] PrefixSearch: Make sure $prefix is a string

https://gerrit.wikimedia.org/r/1059485

Mon, Aug 5, 6:26 AM · MW-1.42-notes, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), MediaWiki-Search, Wikimedia-production-error, Discovery-Search

Sun, Aug 4

Pppery moved T31532: Increase search functionality of Special:Listusers & site logs by allowing wildcard searches from To triage to Maintenance reports on the MediaWiki-Special-pages board.
Sun, Aug 4, 4:36 PM · MediaWiki-User-management, MediaWiki-Special-pages, Discovery-Search, Discovery-ARCHIVED, MediaWiki-Search
Pppery added a project to T31532: Increase search functionality of Special:Listusers & site logs by allowing wildcard searches: MediaWiki-User-management.
Sun, Aug 4, 4:36 PM · MediaWiki-User-management, MediaWiki-Special-pages, Discovery-Search, Discovery-ARCHIVED, MediaWiki-Search
gerritbot added a project to T365565: InvalidArgumentException: Value 4 must be either string or LikeMatch: Patch-For-Review.
Sun, Aug 4, 7:32 AM · MW-1.42-notes, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), MediaWiki-Search, Wikimedia-production-error, Discovery-Search
gerritbot added a comment to T365565: InvalidArgumentException: Value 4 must be either string or LikeMatch.

Change #1059485 had a related patch set uploaded (by RhinosF1; author: Lucas Werkmeister (WMDE)):

[mediawiki/core@REL1_42] PrefixSearch: Make sure $prefix is a string

https://gerrit.wikimedia.org/r/1059485

Sun, Aug 4, 7:32 AM · MW-1.42-notes, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), MediaWiki-Search, Wikimedia-production-error, Discovery-Search

Tue, Jul 30

ReleaseTaggerBot added a project to T344806: cirrussearch-ignored-headings is used in WikiTextStructure: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).
Tue, Jul 30, 2:00 PM · MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Technical-Debt, MediaWiki-Search, Discovery-Search
gerritbot added a comment to T344806: cirrussearch-ignored-headings is used in WikiTextStructure.

Change #951900 merged by jenkins-bot:

[mediawiki/core@master] WikiTextStructure: Drop message fallback to old cirrussearch message

https://gerrit.wikimedia.org/r/951900

Tue, Jul 30, 1:50 PM · MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Technical-Debt, MediaWiki-Search, Discovery-Search

Mon, Jul 29

gerritbot added a comment to T344806: cirrussearch-ignored-headings is used in WikiTextStructure.

Change #1057978 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CirrusSearch@master] i18n: Drop 'cirrussearch-ignored-headings', now unused

https://gerrit.wikimedia.org/r/1057978

Mon, Jul 29, 11:50 PM · MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Technical-Debt, MediaWiki-Search, Discovery-Search
dr0ptp4kt moved T369461: UserEditCountUpdate: "Cannot execute Wikimedia\Rdbms\Database::runOnTransactionIdleCallbacks critical section while session state is out of sync" triggered from some API call initiated by Commons search from needs triage to watching / waiting on the Discovery-Search board.
Mon, Jul 29, 3:33 PM · Discovery-Search, MediaWiki-Search, Wikimedia-production-error
dr0ptp4kt updated subscribers of T369461: UserEditCountUpdate: "Cannot execute Wikimedia\Rdbms\Database::runOnTransactionIdleCallbacks critical section while session state is out of sync" triggered from some API call initiated by Commons search.

@MarkTraceur is this possibly for media search for your team?

Mon, Jul 29, 3:33 PM · Discovery-Search, MediaWiki-Search, Wikimedia-production-error

Fri, Jul 26

Jdlrobson removed a project from T369810: On Commons the special search does not use full width: Web-Team-Backlog.
Fri, Jul 26, 1:58 AM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons

Thu, Jul 25

Krinkle moved T369461: UserEditCountUpdate: "Cannot execute Wikimedia\Rdbms\Database::runOnTransactionIdleCallbacks critical section while session state is out of sync" triggered from some API call initiated by Commons search from Untriaged to Jul 2024 on the Wikimedia-production-error board.

Indeed, Rdbms is detecting this and reporting it. It's not causing it. It's not clear which component is causing it, but they seem to have Search as common referer, perhaps we can investigate from there to see what it is?

Thu, Jul 25, 3:24 PM · Discovery-Search, MediaWiki-Search, Wikimedia-production-error

Wed, Jul 24

WMDE-Fisch moved T323345: Vector search does unnecessary redirects (including a double redirect) when clicking a search result from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2024-07-24 board.
Wed, Jul 24, 2:59 PM · WMDE-TechWish-Sprint-2024-08-13, WMDE-TechWish-Sprint-2024-07-24, WMDE-TechWish-Sprint-2024-07-10, WMDE-TechWish-Sprint-2024-06-26, Unplanned-Sprint-Work, Patch-For-Review, WMDE-TechWish-Maintenance, Advanced-Search, MediaWiki-Search, Desktop Improvements (Vector 2022)
WMDE-Fisch added a project to T323345: Vector search does unnecessary redirects (including a double redirect) when clicking a search result: WMDE-TechWish-Sprint-2024-07-24.
Wed, Jul 24, 2:49 PM · WMDE-TechWish-Sprint-2024-08-13, WMDE-TechWish-Sprint-2024-07-24, WMDE-TechWish-Sprint-2024-07-10, WMDE-TechWish-Sprint-2024-06-26, Unplanned-Sprint-Work, Patch-For-Review, WMDE-TechWish-Maintenance, Advanced-Search, MediaWiki-Search, Desktop Improvements (Vector 2022)

Mon, Jul 22

Gehel moved T369810: On Commons the special search does not use full width from needs triage to watching / waiting on the Discovery-Search board.
Mon, Jul 22, 1:45 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons

Fri, Jul 19

TJones updated subscribers of T329834: Cannot search partial Javanese script titles.

This has been rolling around in my head for a while and something related came up today, so I wanted to jot down some notes to my future self, or to anyone else who may work on this.

Fri, Jul 19, 3:59 PM · CirrusSearch, Discovery-Search, MediaWiki-Search

Jul 16 2024

Kghbln added a comment to T231827: Data too long for column 'si_title'.

@Paladox It would be fantastic if you could continue your work.

Jul 16 2024, 7:04 PM · affects-Miraheze, Patch-For-Review, Discovery-Search, MediaWiki-Search
GMikesell-WMF updated the task description for T367375: Search page doesn't work in dark mode.
Jul 16 2024, 6:26 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), FY2023-24-WE 2.1 Typography and palette customizations, Discovery-Search, SDAW-SearchVue, Web-Team-Backlog (FY2023-24 Q4 Sprint 6), MediaWiki-Search, Advanced-Search
GMikesell-WMF added a comment to T367375: Search page doesn't work in dark mode.

@Jdlrobson "Search" is white in PROD and fail contrast while Test.Wiki was black (as seen in my previous test)

Jul 16 2024, 6:25 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), FY2023-24-WE 2.1 Typography and palette customizations, Discovery-Search, SDAW-SearchVue, Web-Team-Backlog (FY2023-24 Q4 Sprint 6), MediaWiki-Search, Advanced-Search
AUgolnikova-WMF moved T369810: On Commons the special search does not use full width from Triage to MediaSearch on the Structured-Data-Backlog board.
Jul 16 2024, 8:23 AM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons

Jul 15 2024

TheDJ changed the status of T107875: Use InnoDB engine for searchindex table in MySQL from Open to Stalled.

This is currently blocked on all our testcases relying on tables to be cloneable, but innoDB cannot create a TEMPORARY table of a table that has a FULLTEXT index.

Jul 15 2024, 7:18 PM · User-TheDJ, Patch-Needs-Improvement, MediaWiki-Installer, MediaWiki-Search
TheDJ changed the status of T249976: Convert searchindex UNIQUE to PK from Open to Stalled.
Jul 15 2024, 7:18 PM · Patch-For-Review, User-TheDJ, MediaWiki-Search, Discovery-Search, Platform Team Workboards (External Code Reviews), Schema-change
TheDJ changed the status of T231827: Data too long for column 'si_title' from Open to Stalled.
Jul 15 2024, 7:18 PM · affects-Miraheze, Patch-For-Review, Discovery-Search, MediaWiki-Search
Gehel added projects to T369810: On Commons the special search does not use full width: Web-Team-Backlog, Structured-Data-Backlog.
Jul 15 2024, 3:22 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons

Jul 11 2024

egardner updated subscribers of T369810: On Commons the special search does not use full width.

Hey @Prototyperspective, these sound like reasonable ideas for how to improve the user experience here, so I want to bring this to the attention of the Structured Data team (who are the official maintainers of this feature AFAIK). @AUgolnikova-WMF or @Sannita may be able to move this task to the appropriate place for triaging. I will say that I think the team's current focus is on improving UploadWizard, so this might not be an immediate priority.

Jul 11 2024, 10:56 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons
Prototyperspective added a comment to T369810: On Commons the special search does not use full width.

Thanks for CCing. @egardner Yes of course. The Media search is much better. However, there are several problems with it due to which in practice one often has to resort to the Special search. The better solution would be to improve Media search further so that Special search is not needed anymore at all (that would be separate issues). Two main problems with it are that Cat-a-lot (which is very useful especially on WMC) does not work in Media search and that it doesn't have this dropdown for search operators.

Jul 11 2024, 10:06 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons
egardner added a comment to T369810: On Commons the special search does not use full width.

Hi @Prototyperspective – are you familiar with Special:MediaSearch on commons? Here's an example of it in action:

Jul 11 2024, 4:38 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons
Aklapper reopened T369810: On Commons the special search does not use full width as "Open".

CC'ing more folks who were involved in this change to get another opinion in this ticket.

Jul 11 2024, 3:51 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons
Prototyperspective added a comment to T369810: On Commons the special search does not use full width.

I already knew about this research and agree with the findings and what it means for Wikipedia. I don't think it applies here much or at all because these are search results. The user usually just glances over them, like their filetitles and thumbnails. The special search looks quite broken currently and there could at least be settings to make use full width (actually on Wikipedia there now seems to be a reading view setting for width so I guess the same could be used here).

Jul 11 2024, 2:54 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons
Aklapper closed T369810: On Commons the special search does not use full width as Declined.

the space should be used until a preview is shown there, just like with the modern not-broken wall-of-images-view Media search results (example) which use all available width until an item is clicked for preview

Jul 11 2024, 2:49 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons
Prototyperspective reopened T369810: On Commons the special search does not use full width as "Open".

@Aklapper That only relates to what would be needed for this problem to be fixed – in specific that the default for WMC needs to be different than other Wikimedia sites, eg site-specific changes on top of the default page layout that makes it use a wider width.

Jul 11 2024, 2:38 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons
Aklapper added a comment to T369810: On Commons the special search does not use full width.

The empty space is used for interwiki search results or previews in other cases. Page layout shouldn't differ across pages, thus empty space in this case when there are no interwiki search results or previews.

Jul 11 2024, 12:52 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons
Prototyperspective added a comment to T369810: On Commons the special search does not use full width.

@Aklapper I don't think this should be closed and it seems way to quick to close it – I don't understand your explanation. When I click on a file in these search results the page is opened instead of a preview showing on the right. Whether or not it's intentional doesn't make it any better, if anything it would be a bigger problem and indicate that it would be easier to fix. And remains the case that the Special search UI is broken. Could you please clarify what you mean in the sense of why you think this is not a valid issue?

Jul 11 2024, 12:39 PM · SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Search, Discovery-Search, Commons
Prototyperspective reopened T369808: The Commons search "deepcategory" operator often does not work (Deep category query returned too many categories) as "Open".

@Aklapper That is not true. It does work well here for example (which has been very useful to find files missing in the cat) and this category contains thousands of files.

Jul 11 2024, 12:29 PM · Discovery-Search, CirrusSearch, Commons
Aklapper merged task T369808: The Commons search "deepcategory" operator often does not work (Deep category query returned too many categories) into T194449: Support negatives for the deepcategory keyword in AdvancedSearch.
Jul 11 2024, 12:21 PM · Discovery-Search, CirrusSearch, Commons
Aklapper added a comment to T369808: The Commons search "deepcategory" operator often does not work (Deep category query returned too many categories).

The operator works but AFAIK negation is currently not supported.

Jul 11 2024, 12:20 PM · Discovery-Search, CirrusSearch, Commons