Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explicit that gradle build ignores quarkus.application.name #37963

Conversation

swissgrammie
Copy link

…le groject name when building with gradle

When following the guide i hit a problem that my expected property file wasnt being used, i am not a spring expert and so i assumed the issue was on the spring cloud config server side but in reality since quarkus 3 gradle settings about the project name override the quarkus.application.name setting discussed and explicitly set in the guide.

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 30, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)
  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@swissgrammie swissgrammie changed the title added line to explain that the spring application name is set by grad… Make explicit that gradle build ignores quarkus.application.name Dec 30, 2023
Copy link

github-actions bot commented Dec 30, 2023

🙈 The PR is closed and the preview is expired.

@gsmet gsmet force-pushed the spring-cloud-config-gradle-application-name branch from c613db9 to 147f9a2 Compare June 7, 2024 15:49
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded things a bit and made it a TIP.

Let's wait for CI and merge.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 7, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 7, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 147f9a2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 1c3f1cc into quarkusio:main Jun 8, 2024
5 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 8, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 8, 2024
@gsmet
Copy link
Member

gsmet commented Jun 8, 2024

Thanks for taking the time to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants