Remove '-moz-transform' (to avoid web compat issues when supporting 'zoom')
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox120 | --- | fixed |
People
(Reporter: zcorpan, Assigned: emilio)
References
(Regressed 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(3 files, 1 obsolete file)
See https://bugzilla.mozilla.org/show_bug.cgi?id=390936#c104
This should probably be a pref so it's possible to test with and without support for -moz-transform
and so it's easy to change direction if it turns out it's less bad to support -moz-transform
.
Assignee | ||
Comment 1•11 months ago
|
||
It's already a pref (layout.css.prefixes.transforms
)
Reporter | ||
Comment 2•11 months ago
|
||
OK nice! Then this bug is about flipping the default value.
Assignee | ||
Comment 3•11 months ago
|
||
This probably needs a couple test fixes.
Updated•11 months ago
|
Assignee | ||
Comment 4•11 months ago
|
||
We want to disable prefixed transforms to see if it's feasible to ship
zoom without them.
Make tests use un-prefixed transforms.
Assignee | ||
Comment 5•11 months ago
|
||
For reference I used the following sed / grep combination for most of the changes above:
function replace() {
echo "replacing $1 to $2"
rg -l "$1" | xargs sed -i -E -e s/"$1"/"$2"/g
}
replace '\-moz-perspective-origin:' 'perspective-origin:'
replace '\-moz-transform:' 'transform:'
# etc
Updated•11 months ago
|
Assignee | ||
Comment 6•11 months ago
|
||
Depends on D189760
Assignee | ||
Comment 7•11 months ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9e0c6f82d15 Automatic fixes to avoid using prefixed transforms in tests. r=layout-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/81279ad55cef Use another alias other than moz-transform to test use counters, and other manual fix-ups. r=layout-reviewers,jfkthame
Assignee | ||
Updated•11 months ago
|
Comment 9•11 months ago
|
||
bugherder |
Comment 10•10 months ago
|
||
The severity field is not set for this bug.
:dshin, could you have a look please?
For more information, please visit BugBot documentation.
Updated•10 months ago
|
Updated•10 months ago
|
Comment 11•10 months ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/facd9f92e1f5 Disable -moz-transform and enable zoom on Nightly. r=zcorpan
Comment 12•10 months ago
|
||
Backed out for causing failures on backface-visibility-1b.html
- backout: https://hg.mozilla.org/integration/autoland/rev/1bfcea9b6627b3f166edbc82abe3a90f62c4a417
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=KF77GYcQQA6Csmolkm925g.0&revision=facd9f92e1f57dbadfba1397e8b2463c53729640
- failure log: https://treeherder.mozilla.org/logviewer?job_id=433092486&repo=autoland&lineNumber=10074
Comment 13•10 months ago
•
|
||
Also failing:
- TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Unused allowlist item: {"sourceName":"/\bscrollbars\.css$/i","errorMessage":"/Unknown property ‘zoom’/i","isFromDevTools":false} -
- TEST-UNEXPECTED-FAIL | /resize-observer/svg.html | test17: observe g:rect content, border and device-pixel-content boxes with zoom - assert_equals: expected 50 but got 4.6833343505859375
Assignee | ||
Updated•10 months ago
|
Comment 14•10 months ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/793a305aa062 Disable -moz-transform and enable zoom on Nightly. r=zcorpan
Comment 15•10 months ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/a0041460ad93 Fix property_database.js to account for transform prefixes.
Comment 16•10 months ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/10dec6063e0e Add zoom entry to property_database.js
Comment 17•10 months ago
|
||
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8d20d2ae8ad Fix eslint. r=fix CLOSED TREE
Comment 18•10 months ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/fafeb43eefd1 A couple other mochitest fixes.
Comment 19•10 months ago
|
||
bugherder |
Assignee | ||
Updated•10 months ago
|
Updated•10 months ago
|
Updated•10 months ago
|
Assignee | ||
Comment 20•10 months ago
|
||
Code like the one from comment 7 seems reasonable. Let's try to disable
prefixed transitions along with prefixed transforms in order to minimize
the compat fallout from CSS zoom.
While I was at it I also fixed the prefixed animation entries in the
property database and crashtests. But those aliases remain enabled.
Comment 21•10 months ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #20)
Created attachment 9360757 [details]
Bug 1855763 - Remove transition prefixes from nightly too. r=zcorpan,#layout
Was this patch supposed to be for bug 1861730?
Comment 22•10 months ago
|
||
Comment on attachment 9360757 [details]
Bug 1855763 - Remove transition prefixes from nightly too. r=zcorpan,#layout
Revision D192129 was moved to bug 1861730. Setting attachment 9360757 [details] to obsolete.
Assignee | ||
Comment 23•10 months ago
|
||
Yeah, thanks!
Assignee | ||
Updated•10 months ago
|
Comment 24•10 months ago
|
||
Docs changes for this can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/29785
Updated•9 months ago
|
Description
•