Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl/mmp 3037/caip multichain rename methods #26928

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Sep 4, 2024

Description

  • Rename provider_authorize -> wallet_createSession
  • Rename provider_requests -> wallet_invokeMethod
  • Format eth_subscription responses with wallet_notify

Open in GitHub Codespaces

Related issues

See: https://github.com/MetaMask/MetaMask-planning/issues/3037

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@jiexi jiexi marked this pull request as ready for review September 5, 2024 15:19
@jiexi jiexi requested a review from a team as a code owner September 5, 2024 15:19
@jiexi jiexi merged commit 577f337 into caip-multichain Sep 5, 2024
14 of 16 checks passed
@jiexi jiexi deleted the jl/mmp-3037/caip-multichain-rename-methods branch September 5, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants